hv_netvsc: copy_to_send buf can be void
authorStephen Hemminger <stephen@networkplumber.org>
Wed, 13 Dec 2017 00:48:35 +0000 (16:48 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Dec 2017 20:57:38 +0000 (15:57 -0500)
Since only caller does not care about return value.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/netvsc.c

index e5d16a8..53a366f 100644 (file)
@@ -701,19 +701,18 @@ static u32 netvsc_get_next_send_section(struct netvsc_device *net_device)
        return NETVSC_INVALID_INDEX;
 }
 
-static u32 netvsc_copy_to_send_buf(struct netvsc_device *net_device,
-                                  unsigned int section_index,
-                                  u32 pend_size,
-                                  struct hv_netvsc_packet *packet,
-                                  struct rndis_message *rndis_msg,
-                                  struct hv_page_buffer *pb,
-                                  struct sk_buff *skb)
+static void netvsc_copy_to_send_buf(struct netvsc_device *net_device,
+                                   unsigned int section_index,
+                                   u32 pend_size,
+                                   struct hv_netvsc_packet *packet,
+                                   struct rndis_message *rndis_msg,
+                                   struct hv_page_buffer *pb,
+                                   struct sk_buff *skb)
 {
        char *start = net_device->send_buf;
        char *dest = start + (section_index * net_device->send_section_size)
                     + pend_size;
        int i;
-       u32 msg_size = 0;
        u32 padding = 0;
        u32 page_count = packet->cp_partial ? packet->rmsg_pgcnt :
                packet->page_buf_cnt;
@@ -733,16 +732,11 @@ static u32 netvsc_copy_to_send_buf(struct netvsc_device *net_device,
                u32 len = pb[i].len;
 
                memcpy(dest, (src + offset), len);
-               msg_size += len;
                dest += len;
        }
 
-       if (padding) {
+       if (padding)
                memset(dest, 0, padding);
-               msg_size += padding;
-       }
-
-       return msg_size;
 }
 
 static inline int netvsc_send_pkt(