btrfs: zoned: wait for existing extents before truncating
authorNaohiro Aota <naohiro.aota@wdc.com>
Thu, 4 Feb 2021 10:22:09 +0000 (19:22 +0900)
committerDavid Sterba <dsterba@suse.com>
Tue, 9 Feb 2021 01:46:07 +0000 (02:46 +0100)
When truncating a file, file buffers which have already been allocated
but not yet written may be truncated. Truncating these buffers could
cause breakage of a sequential write pattern in a block group if the
truncated blocks are for example followed by blocks allocated to another
file. To avoid this problem, always wait for write out of all unwritten
buffers before proceeding with the truncate execution.

Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index c4779cd..535abf8 100644 (file)
@@ -5169,6 +5169,15 @@ static int btrfs_setsize(struct inode *inode, struct iattr *attr)
                btrfs_drew_write_unlock(&root->snapshot_lock);
                btrfs_end_transaction(trans);
        } else {
+               struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
+
+               if (btrfs_is_zoned(fs_info)) {
+                       ret = btrfs_wait_ordered_range(inode,
+                                       ALIGN(newsize, fs_info->sectorsize),
+                                       (u64)-1);
+                       if (ret)
+                               return ret;
+               }
 
                /*
                 * We're truncating a file that used to have good data down to