ipv6: remove redundant assignment to variable err
authorColin Ian King <colin.king@canonical.com>
Fri, 11 Sep 2020 10:35:09 +0000 (11:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Sep 2020 21:48:25 +0000 (14:48 -0700)
The variable err is being initialized with a value that is never read and
it is being updated later with a new value. The initialization is redundant
and can be removed.  Also re-order variable declarations in reverse
Christmas tree ordering.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c

index 5e7e25e..e8ee207 100644 (file)
@@ -5284,9 +5284,10 @@ static int ip6_route_multipath_del(struct fib6_config *cfg,
 {
        struct fib6_config r_cfg;
        struct rtnexthop *rtnh;
+       int last_err = 0;
        int remaining;
        int attrlen;
-       int err = 1, last_err = 0;
+       int err;
 
        remaining = cfg->fc_mp_len;
        rtnh = (struct rtnexthop *)cfg->fc_mp;