ovl: remove unnecessary lock check
authoryoungjun <her0gyugyu@gmail.com>
Sun, 7 Jun 2020 09:04:06 +0000 (02:04 -0700)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 8 Jun 2020 07:57:19 +0000 (09:57 +0200)
Directory is always locked until "out_unlock" label.  So lock check is not
needed.

Signed-off-by: youngjun <her0gyugyu@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/super.c

index 8d8cd46..91476bc 100644 (file)
@@ -676,11 +676,8 @@ static struct dentry *ovl_workdir_create(struct ovl_fs *ofs,
        struct dentry *work;
        int err;
        bool retried = false;
-       bool locked = false;
 
        inode_lock_nested(dir, I_MUTEX_PARENT);
-       locked = true;
-
 retry:
        work = lookup_one_len(name, ofs->workbasedir, strlen(name));
 
@@ -741,9 +738,7 @@ retry:
                goto out_err;
        }
 out_unlock:
-       if (locked)
-               inode_unlock(dir);
-
+       inode_unlock(dir);
        return work;
 
 out_dput: