iomap: remove the iomap arguments to ->page_{prepare,done}
authorChristoph Hellwig <hch@lst.de>
Wed, 11 Aug 2021 01:33:03 +0000 (18:33 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 17 Aug 2021 04:26:33 +0000 (21:26 -0700)
These aren't actually used by the only instance implementing the methods.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/gfs2/bmap.c
fs/iomap/buffered-io.c
include/linux/iomap.h

index ed8b67b..5414c2c 100644 (file)
@@ -1002,7 +1002,7 @@ static void gfs2_write_unlock(struct inode *inode)
 }
 
 static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos,
-                                  unsigned len, struct iomap *iomap)
+                                  unsigned len)
 {
        unsigned int blockmask = i_blocksize(inode) - 1;
        struct gfs2_sbd *sdp = GFS2_SB(inode);
@@ -1013,8 +1013,7 @@ static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos,
 }
 
 static void gfs2_iomap_page_done(struct inode *inode, loff_t pos,
-                                unsigned copied, struct page *page,
-                                struct iomap *iomap)
+                                unsigned copied, struct page *page)
 {
        struct gfs2_trans *tr = current->journal_info;
        struct gfs2_inode *ip = GFS2_I(inode);
index 43b9354..7e794a3 100644 (file)
@@ -615,7 +615,7 @@ iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, unsigned flags,
                return -EINTR;
 
        if (page_ops && page_ops->page_prepare) {
-               status = page_ops->page_prepare(inode, pos, len, iomap);
+               status = page_ops->page_prepare(inode, pos, len);
                if (status)
                        return status;
        }
@@ -648,7 +648,7 @@ out_unlock:
 
 out_no_page:
        if (page_ops && page_ops->page_done)
-               page_ops->page_done(inode, pos, 0, NULL, iomap);
+               page_ops->page_done(inode, pos, 0, NULL);
        return status;
 }
 
@@ -724,7 +724,7 @@ static size_t iomap_write_end(struct inode *inode, loff_t pos, size_t len,
        if (old_size < pos)
                pagecache_isize_extended(inode, old_size, pos);
        if (page_ops && page_ops->page_done)
-               page_ops->page_done(inode, pos, ret, page, iomap);
+               page_ops->page_done(inode, pos, ret, page);
        put_page(page);
 
        if (ret < len)
index b8ec145..72696a5 100644 (file)
@@ -126,10 +126,9 @@ static inline bool iomap_inline_data_valid(struct iomap *iomap)
  * associated page could not be obtained.
  */
 struct iomap_page_ops {
-       int (*page_prepare)(struct inode *inode, loff_t pos, unsigned len,
-                       struct iomap *iomap);
+       int (*page_prepare)(struct inode *inode, loff_t pos, unsigned len);
        void (*page_done)(struct inode *inode, loff_t pos, unsigned copied,
-                       struct page *page, struct iomap *iomap);
+                       struct page *page);
 };
 
 /*