net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 19 Jun 2021 13:50:21 +0000 (16:50 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jun 2021 19:16:58 +0000 (12:16 -0700)
These functions return negative ENODATA but the minus sign was left out
in the tests.

Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Guvenc Gulce <guvenc@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_stats.c

index 614013e..e80e34f 100644 (file)
@@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)
                        continue;
                if (!skip_serv) {
                        rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv);
-                       if (rc_srv && rc_srv != ENODATA)
+                       if (rc_srv && rc_srv != -ENODATA)
                                break;
                } else {
                        skip_serv = 0;
                }
                rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv);
-               if (rc_clnt && rc_clnt != ENODATA) {
+               if (rc_clnt && rc_clnt != -ENODATA) {
                        skip_serv = 1;
                        break;
                }
-               if (rc_clnt == ENODATA && rc_srv == ENODATA)
+               if (rc_clnt == -ENODATA && rc_srv == -ENODATA)
                        break;
        }
        mutex_unlock(&net->smc.mutex_fback_rsn);