mt76: mt7615: Use kmemdup in mt7615_queue_key_update()
authorYueHaibing <yuehaibing@huawei.com>
Thu, 28 May 2020 07:48:56 +0000 (07:48 +0000)
committerFelix Fietkau <nbd@nbd.name>
Thu, 28 May 2020 15:57:25 +0000 (17:57 +0200)
Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/main.c

index 320dfda..c26f99b 100644 (file)
@@ -290,12 +290,11 @@ mt7615_queue_key_update(struct mt7615_dev *dev, enum set_key_cmd cmd,
        wd->type = MT7615_WTBL_KEY_DESC;
        wd->sta = msta;
 
-       wd->key.key = kzalloc(key->keylen, GFP_KERNEL);
+       wd->key.key = kmemdup(key->key, key->keylen, GFP_KERNEL);
        if (!wd->key.key) {
                kfree(wd);
                return -ENOMEM;
        }
-       memcpy(wd->key.key, key->key, key->keylen);
        wd->key.cipher = key->cipher;
        wd->key.keyidx = key->keyidx;
        wd->key.keylen = key->keylen;