scsi: fnic: Remove set but not used 'eth_hdrs_stripped'
authorJason Yan <yanaijie@huawei.com>
Mon, 31 Aug 2020 08:11:26 +0000 (16:11 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 3 Sep 2020 02:49:07 +0000 (22:49 -0400)
This addresses the following gcc warning with "make W=1":

drivers/scsi/fnic/fnic_fcs.c: In function ‘fnic_rq_cmpl_frame_recv’:
drivers/scsi/fnic/fnic_fcs.c:840:15: warning: variable
‘eth_hdrs_stripped’ set but not used [-Wunused-but-set-variable]
  840 |  unsigned int eth_hdrs_stripped;
      |               ^~~~~~~~~~~~~~~~~

Link: https://lore.kernel.org/r/20200831081126.3251288-5-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fnic/fnic_fcs.c

index 643622f..e3384af 100644 (file)
@@ -831,7 +831,6 @@ static void fnic_rq_cmpl_frame_recv(struct vnic_rq *rq, struct cq_desc
        struct sk_buff *skb;
        struct fc_frame *fp;
        struct fnic_stats *fnic_stats = &fnic->fnic_stats;
-       unsigned int eth_hdrs_stripped;
        u8 type, color, eop, sop, ingress_port, vlan_stripped;
        u8 fcoe = 0, fcoe_sof, fcoe_eof;
        u8 fcoe_fc_crc_ok = 1, fcoe_enc_error = 0;
@@ -861,7 +860,6 @@ static void fnic_rq_cmpl_frame_recv(struct vnic_rq *rq, struct cq_desc
                                   &ingress_port, &packet_error,
                                   &fcoe_enc_error, &fcs_ok, &vlan_stripped,
                                   &vlan);
-               eth_hdrs_stripped = 1;
                skb_trim(skb, fcp_bytes_written);
                fr_sof(fp) = sof;
                fr_eof(fp) = eof;
@@ -878,7 +876,6 @@ static void fnic_rq_cmpl_frame_recv(struct vnic_rq *rq, struct cq_desc
                                    &tcp_udp_csum_ok, &udp, &tcp,
                                    &ipv4_csum_ok, &ipv6, &ipv4,
                                    &ipv4_fragment, &fcs_ok);
-               eth_hdrs_stripped = 0;
                skb_trim(skb, bytes_written);
                if (!fcs_ok) {
                        atomic64_inc(&fnic_stats->misc_stats.frame_errors);