crypto: xor - Remove unused variable count in do_xor_speed
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 6 Oct 2020 19:58:48 +0000 (12:58 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 8 Oct 2020 05:38:06 +0000 (16:38 +1100)
Clang warns:

crypto/xor.c:101:4: warning: variable 'count' is uninitialized when used
here [-Wuninitialized]
                        count++;
                        ^~~~~
crypto/xor.c:86:17: note: initialize the variable 'count' to silence
this warning
        int i, j, count;
                       ^
                        = 0
1 warning generated.

After the refactoring to use ktime that happened in this function, count
is only assigned, never read. Just remove the variable to get rid of the
warning.

Fixes: c055e3eae0f1 ("crypto: xor - use ktime for template benchmarking")
Link: https://github.com/ClangBuiltLinux/linux/issues/1171
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/xor.c

index a0badbc..eacbf4f 100644 (file)
@@ -83,7 +83,7 @@ static void __init
 do_xor_speed(struct xor_block_template *tmpl, void *b1, void *b2)
 {
        int speed;
-       int i, j, count;
+       int i, j;
        ktime_t min, start, diff;
 
        tmpl->next = template_list;
@@ -98,8 +98,6 @@ do_xor_speed(struct xor_block_template *tmpl, void *b1, void *b2)
                        mb(); /* prevent loop optimzation */
                        tmpl->do_2(BENCH_SIZE, b1, b2);
                        mb();
-                       count++;
-                       mb();
                }
                diff = ktime_sub(ktime_get(), start);
                if (diff < min)