dmaengine: mmp_tdma: Reset channel error on release
authorLubomir Rintel <lkundrak@v3.sk>
Sun, 19 Apr 2020 16:49:09 +0000 (18:49 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 23 Apr 2020 07:14:30 +0000 (12:44 +0530)
When a channel configuration fails, the status of the channel is set to
DEV_ERROR so that an attempt to submit it fails. However, this status
sticks until the heat end of the universe, making it impossible to
recover from the error.

Let's reset it when the channel is released so that further use of the
channel with correct configuration is not impacted.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Link: https://lore.kernel.org/r/20200419164912.670973-5-lkundrak@v3.sk
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mmp_tdma.c

index 51e08c1..d683232 100644 (file)
@@ -363,6 +363,8 @@ static void mmp_tdma_free_descriptor(struct mmp_tdma_chan *tdmac)
                gen_pool_free(gpool, (unsigned long)tdmac->desc_arr,
                                size);
        tdmac->desc_arr = NULL;
+       if (tdmac->status == DMA_ERROR)
+               tdmac->status = DMA_COMPLETE;
 
        return;
 }