netlink: remove hash::nelems check in netlink_insert
authorLi RongQing <lirongqing@baidu.com>
Tue, 11 Sep 2018 01:05:01 +0000 (09:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Sep 2018 07:08:44 +0000 (00:08 -0700)
The type of hash::nelems has been changed from size_t to atom_t
which in fact is int, so not need to check if BITS_PER_LONG, that
is bit number of size_t, is bigger than 32

and rht_grow_above_max() will be called to check if hashtable is
too big, ensure it can not bigger than 1<<31

Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c

index b4a29bc..e3a0538 100644 (file)
@@ -574,11 +574,6 @@ static int netlink_insert(struct sock *sk, u32 portid)
        if (nlk_sk(sk)->bound)
                goto err;
 
-       err = -ENOMEM;
-       if (BITS_PER_LONG > 32 &&
-           unlikely(atomic_read(&table->hash.nelems) >= UINT_MAX))
-               goto err;
-
        nlk_sk(sk)->portid = portid;
        sock_hold(sk);