2 # SPDX-License-Identifier: GPL-2.0
4 # Test various interface configuration scenarios. Observe that configurations
5 # deemed valid by mlxsw succeed, invalid configurations fail and that no traces
6 # are produced. To prevent the test from passing in case traces are produced,
7 # the user can set the 'kernel.panic_on_warn' and 'kernel.panic_on_oops'
8 # sysctls in its environment.
10 lib_dir=$(dirname $0)/../../../net/forwarding
14 rif_inherit_bridge_addr_test
15 rif_non_inherit_bridge_addr_test
16 vlan_interface_deletion_test
18 bridge_vlan_flags_test
22 vlan_rif_refcount_test
23 subport_rif_refcount_test
24 vlan_dev_deletion_test
25 lag_unlink_slaves_test
27 vlan_interface_uppers_test
31 source $lib_dir/lib.sh
32 source $lib_dir/devlink_lib.sh
39 ip link set dev $swp1 up
40 ip link set dev $swp2 up
47 ip link set dev $swp2 down
48 ip link set dev $swp1 down
53 local swp1_mac=$(mac_get $swp1)
54 local swp2_mac=$(mac_get $swp2)
58 # $swp1 and $swp2 likely got their IPv6 local addresses already, but
59 # here we need to test the transition to RIF.
60 ip addr flush dev $swp1
61 ip addr flush dev $swp2
64 ip addr add dev $swp1 192.0.2.1/28
67 ip link set dev $swp1 addr 00:11:22:33:44:55
70 # IP address enablement should be rejected if the MAC address prefix
71 # doesn't match other RIFs.
72 ip addr add dev $swp2 192.0.2.2/28 &>/dev/null
73 check_fail $? "IP address addition passed for a device with a wrong MAC"
74 ip addr add dev $swp2 192.0.2.2/28 2>&1 >/dev/null \
75 | grep -q mlxsw_spectrum
76 check_err $? "no extack for IP address addition"
78 ip link set dev $swp2 addr 00:11:22:33:44:66
80 ip addr add dev $swp2 192.0.2.2/28 &>/dev/null
83 # Change of MAC address of a RIF should be forbidden if the new MAC
84 # doesn't share the prefix with other MAC addresses.
85 ip link set dev $swp2 addr 00:11:22:33:00:66 &>/dev/null
86 check_fail $? "change of MAC address passed for a wrong MAC"
87 ip link set dev $swp2 addr 00:11:22:33:00:66 2>&1 >/dev/null \
88 | grep -q mlxsw_spectrum
89 check_err $? "no extack for MAC address change"
91 log_test "RIF - bad MAC change"
93 ip addr del dev $swp2 192.0.2.2/28
94 ip addr del dev $swp1 192.0.2.1/28
96 ip link set dev $swp2 addr $swp2_mac
97 ip link set dev $swp1 addr $swp1_mac
100 rif_inherit_bridge_addr_test()
105 ip addr add dev $swp1 192.0.2.1/28
109 ip link add name br1 up type bridge vlan_filtering 0
110 ip link set dev $swp2 master br1
111 ip addr add dev br1 192.0.2.17/28
114 # Prepare a device with a low MAC address
115 ip link add name d up type dummy
116 ip link set dev d addr 00:11:22:33:44:55
118 # Attach the device to br1. That prompts bridge address change, which
119 # should be vetoed, thus preventing the attachment.
120 ip link set dev d master br1 &>/dev/null
121 check_fail $? "Device with low MAC was permitted to attach a bridge with RIF"
122 ip link set dev d master br1 2>&1 >/dev/null \
123 | grep -q mlxsw_spectrum
124 check_err $? "no extack for bridge attach rejection"
126 ip link set dev $swp2 addr 00:11:22:33:44:55 &>/dev/null
127 check_fail $? "Changing swp2's MAC address permitted"
128 ip link set dev $swp2 addr 00:11:22:33:44:55 2>&1 >/dev/null \
129 | grep -q mlxsw_spectrum
130 check_err $? "no extack for bridge port MAC address change rejection"
132 log_test "RIF - attach port with bad MAC to bridge"
136 ip addr del dev $swp1 192.0.2.1/28
139 rif_non_inherit_bridge_addr_test()
141 local swp2_mac=$(mac_get $swp2)
146 ip addr add dev $swp1 192.0.2.1/28
150 ip link add name br1 up type bridge vlan_filtering 0
151 ip link set dev br1 addr $swp2_mac
152 ip link set dev $swp2 master br1
153 ip addr add dev br1 192.0.2.17/28
156 # Prepare a device with a low MAC address
157 ip link add name d up type dummy
158 ip link set dev d addr 00:11:22:33:44:55
160 # Attach the device to br1. Since the bridge address was set, it should
162 ip link set dev d master br1 &>/dev/null
163 check_err $? "Could not attach a device with low MAC to a bridge with RIF"
165 # Port MAC address change should be allowed for a bridge with set MAC.
166 ip link set dev $swp2 addr 00:11:22:33:44:55
167 check_err $? "Changing swp2's MAC address not permitted"
169 log_test "RIF - attach port with bad MAC to bridge with set MAC"
171 ip link set dev $swp2 addr $swp2_mac
174 ip addr del dev $swp1 192.0.2.1/28
177 vlan_interface_deletion_test()
179 # Test that when a VLAN interface is deleted, its associated router
180 # interface (RIF) is correctly deleted and not leaked. See commit
181 # c360867ec46a ("mlxsw: spectrum: Delete RIF when VLAN device is
182 # removed") for more details
185 ip link add name br0 type bridge vlan_filtering 1
186 ip link set dev $swp1 master br0
188 ip link add link br0 name br0.10 type vlan id 10
189 ip -6 address add 2001:db8:1::1/64 dev br0.10
190 ip link del dev br0.10
192 # If we leaked the previous RIF, then this should produce a trace
193 ip link add link br0 name br0.20 type vlan id 20
194 ip -6 address add 2001:db8:1::1/64 dev br0.20
195 ip link del dev br0.20
197 log_test "vlan interface deletion"
202 bridge_deletion_test()
204 # Test that when a bridge with VLAN interfaces is deleted, we correctly
205 # delete the associated RIFs. See commit 602b74eda813 ("mlxsw:
206 # spectrum_switchdev: Do not leak RIFs when removing bridge") for more
210 ip link add name br0 type bridge vlan_filtering 1
211 ip link set dev $swp1 master br0
212 ip -6 address add 2001:db8::1/64 dev br0
214 ip link add link br0 name br0.10 type vlan id 10
215 ip -6 address add 2001:db8:1::1/64 dev br0.10
217 ip link add link br0 name br0.20 type vlan id 20
218 ip -6 address add 2001:db8:2::1/64 dev br0.20
222 # If we leaked previous RIFs, then this should produce a trace
223 ip -6 address add 2001:db8:1::1/64 dev $swp1
224 ip -6 address del 2001:db8:1::1/64 dev $swp1
226 log_test "bridge deletion"
229 bridge_vlan_flags_test()
231 # Test that when bridge VLAN flags are toggled, we do not take
232 # unnecessary references on related structs. See commit 9e25826ffc94
233 # ("mlxsw: spectrum_switchdev: Fix port_vlan refcounting") for more
237 ip link add name br0 type bridge vlan_filtering 1
238 ip link set dev $swp1 master br0
240 bridge vlan add vid 10 dev $swp1 pvid untagged
241 bridge vlan add vid 10 dev $swp1 untagged
242 bridge vlan add vid 10 dev $swp1 pvid
243 bridge vlan add vid 10 dev $swp1
246 # If we did not handle references correctly, then this should produce a
248 devlink dev reload "$DEVLINK_DEV"
250 # Allow netdevices to be re-created following the reload
253 log_test "bridge vlan flags"
258 # Test that VLAN 1 can be configured over mlxsw ports. In the past it
259 # was used internally for untagged traffic. See commit 47bf9df2e820
260 # ("mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG") for more
264 ip link add link $swp1 name $swp1.1 type vlan id 1
265 check_err $? "did not manage to create vlan 1 when should"
269 ip link del dev $swp1.1
272 lag_bridge_upper_test()
274 # Test that ports cannot be enslaved to LAG devices that have uppers
275 # and that failure is handled gracefully. See commit b3529af6bb0d
276 # ("spectrum: Reference count VLAN entries") for more details
279 ip link add name bond1 type bond mode 802.3ad
281 ip link add name br0 type bridge vlan_filtering 1
282 ip link set dev bond1 master br0
284 ip link set dev $swp1 down
285 ip link set dev $swp1 master bond1 &> /dev/null
286 check_fail $? "managed to enslave port to lag when should not"
288 # This might generate a trace, if we did not handle the failure
290 ip -6 address add 2001:db8:1::1/64 dev $swp1
291 ip -6 address del 2001:db8:1::1/64 dev $swp1
293 log_test "lag with bridge upper"
296 ip link del dev bond1
299 duplicate_vlans_test()
301 # Test that on a given port a VLAN is only used once. Either as VLAN
302 # in a VLAN-aware bridge or as a VLAN device
305 ip link add name br0 type bridge vlan_filtering 1
306 ip link set dev $swp1 master br0
307 bridge vlan add vid 10 dev $swp1
309 ip link add link $swp1 name $swp1.10 type vlan id 10 &> /dev/null
310 check_fail $? "managed to create vlan device when should not"
312 bridge vlan del vid 10 dev $swp1
313 ip link add link $swp1 name $swp1.10 type vlan id 10
314 check_err $? "did not manage to create vlan device when should"
315 bridge vlan add vid 10 dev $swp1 &> /dev/null
316 check_fail $? "managed to add bridge vlan when should not"
318 log_test "duplicate vlans"
320 ip link del dev $swp1.10
324 vlan_rif_refcount_test()
326 # Test that RIFs representing VLAN interfaces are not affected from
327 # ports member in the VLAN. We use the offload indication on routes
328 # configured on the RIF to understand if it was created / destroyed
331 ip link add name br0 type bridge vlan_filtering 1
332 ip link set dev $swp1 master br0
334 ip link set dev $swp1 up
335 ip link set dev br0 up
337 ip link add link br0 name br0.10 up type vlan id 10
338 ip -6 address add 2001:db8:1::1/64 dev br0.10
340 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload
341 check_err $? "vlan rif was not created before adding port to vlan"
343 bridge vlan add vid 10 dev $swp1
344 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload
345 check_err $? "vlan rif was destroyed after adding port to vlan"
347 bridge vlan del vid 10 dev $swp1
348 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload
349 check_err $? "vlan rif was destroyed after removing port from vlan"
351 ip link set dev $swp1 nomaster
352 ip -6 route get fibmatch 2001:db8:1::2 dev br0.10 | grep -q offload
353 check_fail $? "vlan rif was not destroyed after unlinking port from bridge"
355 log_test "vlan rif refcount"
357 ip link del dev br0.10
358 ip link set dev $swp1 down
362 subport_rif_refcount_test()
364 # Test that RIFs representing upper devices of physical ports are
365 # reference counted correctly and destroyed when should. We use the
366 # offload indication on routes configured on the RIF to understand if
367 # it was created / destroyed
370 ip link add name bond1 type bond mode 802.3ad
371 ip link set dev $swp1 down
372 ip link set dev $swp2 down
373 ip link set dev $swp1 master bond1
374 ip link set dev $swp2 master bond1
376 ip link set dev bond1 up
377 ip link add link bond1 name bond1.10 up type vlan id 10
378 ip -6 address add 2001:db8:1::1/64 dev bond1
379 ip -6 address add 2001:db8:2::1/64 dev bond1.10
381 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload
382 check_err $? "subport rif was not created on lag device"
383 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload
384 check_err $? "subport rif was not created on vlan device"
386 ip link set dev $swp1 nomaster
387 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload
388 check_err $? "subport rif of lag device was destroyed when should not"
389 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload
390 check_err $? "subport rif of vlan device was destroyed when should not"
392 ip link set dev $swp2 nomaster
393 ip -6 route get fibmatch 2001:db8:1::2 dev bond1 | grep -q offload
394 check_fail $? "subport rif of lag device was not destroyed when should"
395 ip -6 route get fibmatch 2001:db8:2::2 dev bond1.10 | grep -q offload
396 check_fail $? "subport rif of vlan device was not destroyed when should"
398 log_test "subport rif refcount"
400 ip link del dev bond1.10
401 ip link del dev bond1
404 vlan_dev_deletion_test()
406 # Test that VLAN devices are correctly deleted / unlinked when enslaved
410 ip link add name br10 type bridge
411 ip link add name br20 type bridge
412 ip link add name br30 type bridge
413 ip link add link $swp1 name $swp1.10 type vlan id 10
414 ip link add link $swp1 name $swp1.20 type vlan id 20
415 ip link add link $swp1 name $swp1.30 type vlan id 30
416 ip link set dev $swp1.10 master br10
417 ip link set dev $swp1.20 master br20
418 ip link set dev $swp1.30 master br30
420 # If we did not handle the situation correctly, then these operations
421 # might produce a trace
422 ip link set dev $swp1.30 nomaster
423 ip link del dev $swp1.20
424 # Deletion via ioctl uses different code paths from netlink
425 vconfig rem $swp1.10 &> /dev/null
427 log_test "vlan device deletion"
429 ip link del dev $swp1.30
437 ip link add name bond1 type bond mode 802.3ad
438 ip link set dev $swp1 down
439 ip link set dev $swp2 down
440 ip link set dev $swp1 master bond1
441 ip link set dev $swp2 master bond1
443 ip link add link bond1 name bond1.10 type vlan id 10
444 ip link add link bond1 name bond1.20 type vlan id 20
446 ip link add name br0 type bridge vlan_filtering 1
447 ip link set dev bond1 master br0
449 ip link add name br10 type bridge
450 ip link set dev bond1.10 master br10
452 ip link add name br20 type bridge
453 ip link set dev bond1.20 master br20
456 lag_unlink_slaves_test()
458 # Test that ports are correctly unlinked from their LAG master, when
459 # the LAG and its VLAN uppers are enslaved to bridges
464 ip link set dev $swp1 nomaster
465 check_err $? "lag slave $swp1 was not unlinked from master"
466 ip link set dev $swp2 nomaster
467 check_err $? "lag slave $swp2 was not unlinked from master"
469 # Try to configure corresponding VLANs as router interfaces
470 ip -6 address add 2001:db8:1::1/64 dev $swp1
471 check_err $? "failed to configure ip address on $swp1"
473 ip link add link $swp1 name $swp1.10 type vlan id 10
474 ip -6 address add 2001:db8:10::1/64 dev $swp1.10
475 check_err $? "failed to configure ip address on $swp1.10"
477 ip link add link $swp1 name $swp1.20 type vlan id 20
478 ip -6 address add 2001:db8:20::1/64 dev $swp1.20
479 check_err $? "failed to configure ip address on $swp1.20"
481 log_test "lag slaves unlinking"
483 ip link del dev $swp1.20
484 ip link del dev $swp1.10
485 ip address flush dev $swp1
490 ip link del dev bond1
493 lag_dev_deletion_test()
495 # Test that LAG device is correctly deleted, when the LAG and its VLAN
496 # uppers are enslaved to bridges
501 ip link del dev bond1
503 log_test "lag device deletion"
510 vlan_interface_uppers_test()
512 # Test that uppers of a VLAN interface are correctly sanitized
515 ip link add name br0 type bridge vlan_filtering 1
516 ip link set dev $swp1 master br0
518 ip link add link br0 name br0.10 type vlan id 10
519 ip link add link br0.10 name macvlan0 \
520 type macvlan mode private &> /dev/null
521 check_fail $? "managed to create a macvlan when should not"
523 ip -6 address add 2001:db8:1::1/64 dev br0.10
524 ip link add link br0.10 name macvlan0 type macvlan mode private
525 check_err $? "did not manage to create a macvlan when should"
527 ip link del dev macvlan0
529 ip link add name vrf-test type vrf table 10
530 ip link set dev br0.10 master vrf-test
531 check_err $? "did not manage to enslave vlan interface to vrf"
532 ip link del dev vrf-test
534 ip link add name br-test type bridge
535 ip link set dev br0.10 master br-test &> /dev/null
536 check_fail $? "managed to enslave vlan interface to bridge when should not"
537 ip link del dev br-test
539 log_test "vlan interface uppers"
544 devlink_reload_test()
546 # Test that after executing all the above configuration tests, a
547 # devlink reload can be performed without errors
550 devlink dev reload "$DEVLINK_DEV"
551 check_err $? "devlink reload failed"
553 log_test "devlink reload - last test"