1 // SPDX-License-Identifier: MIT
3 * Copyright © 2014-2018 Intel Corporation
7 #include "intel_context.h"
8 #include "intel_engine_pm.h"
9 #include "intel_gpu_commands.h"
11 #include "intel_ring.h"
12 #include "intel_workarounds.h"
15 * DOC: Hardware workarounds
17 * This file is intended as a central place to implement most [1]_ of the
18 * required workarounds for hardware to work as originally intended. They fall
19 * in five basic categories depending on how/when they are applied:
21 * - Workarounds that touch registers that are saved/restored to/from the HW
22 * context image. The list is emitted (via Load Register Immediate commands)
23 * everytime a new context is created.
24 * - GT workarounds. The list of these WAs is applied whenever these registers
25 * revert to default values (on GPU reset, suspend/resume [2]_, etc..).
26 * - Display workarounds. The list is applied during display clock-gating
28 * - Workarounds that whitelist a privileged register, so that UMDs can manage
29 * them directly. This is just a special case of a MMMIO workaround (as we
30 * write the list of these to/be-whitelisted registers to some special HW
32 * - Workaround batchbuffers, that get executed automatically by the hardware
33 * on every HW context restore.
35 * .. [1] Please notice that there are other WAs that, due to their nature,
36 * cannot be applied from a central place. Those are peppered around the rest
37 * of the code, as needed.
39 * .. [2] Technically, some registers are powercontext saved & restored, so they
40 * survive a suspend/resume. In practice, writing them again is not too
41 * costly and simplifies things. We can revisit this in the future.
46 * Keep things in this file ordered by WA type, as per the above (context, GT,
47 * display, register whitelist, batchbuffer). Then, inside each type, keep the
50 * - Infrastructure functions and macros
51 * - WAs per platform in standard gen/chrono order
52 * - Public functions to init or apply the given workaround type.
55 static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
58 wal->engine_name = engine_name;
61 #define WA_LIST_CHUNK (1 << 4)
63 static void wa_init_finish(struct i915_wa_list *wal)
65 /* Trim unused entries. */
66 if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
67 struct i915_wa *list = kmemdup(wal->list,
68 wal->count * sizeof(*list),
80 DRM_DEBUG_DRIVER("Initialized %u %s workarounds on %s\n",
81 wal->wa_count, wal->name, wal->engine_name);
84 static void _wa_add(struct i915_wa_list *wal, const struct i915_wa *wa)
86 unsigned int addr = i915_mmio_reg_offset(wa->reg);
87 unsigned int start = 0, end = wal->count;
88 const unsigned int grow = WA_LIST_CHUNK;
91 GEM_BUG_ON(!is_power_of_2(grow));
93 if (IS_ALIGNED(wal->count, grow)) { /* Either uninitialized or full. */
96 list = kmalloc_array(ALIGN(wal->count + 1, grow), sizeof(*wa),
99 DRM_ERROR("No space for workaround init!\n");
104 memcpy(list, wal->list, sizeof(*wa) * wal->count);
111 while (start < end) {
112 unsigned int mid = start + (end - start) / 2;
114 if (i915_mmio_reg_offset(wal->list[mid].reg) < addr) {
116 } else if (i915_mmio_reg_offset(wal->list[mid].reg) > addr) {
119 wa_ = &wal->list[mid];
121 if ((wa->clr | wa_->clr) && !(wa->clr & ~wa_->clr)) {
122 DRM_ERROR("Discarding overwritten w/a for reg %04x (clear: %08x, set: %08x)\n",
123 i915_mmio_reg_offset(wa_->reg),
126 wa_->set &= ~wa->clr;
132 wa_->read |= wa->read;
138 wa_ = &wal->list[wal->count++];
141 while (wa_-- > wal->list) {
142 GEM_BUG_ON(i915_mmio_reg_offset(wa_[0].reg) ==
143 i915_mmio_reg_offset(wa_[1].reg));
144 if (i915_mmio_reg_offset(wa_[1].reg) >
145 i915_mmio_reg_offset(wa_[0].reg))
148 swap(wa_[1], wa_[0]);
152 static void wa_add(struct i915_wa_list *wal, i915_reg_t reg,
153 u32 clear, u32 set, u32 read_mask)
155 struct i915_wa wa = {
166 wa_write_clr_set(struct i915_wa_list *wal, i915_reg_t reg, u32 clear, u32 set)
168 wa_add(wal, reg, clear, set, clear);
172 wa_write(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
174 wa_write_clr_set(wal, reg, ~0, set);
178 wa_write_or(struct i915_wa_list *wal, i915_reg_t reg, u32 set)
180 wa_write_clr_set(wal, reg, set, set);
184 wa_write_clr(struct i915_wa_list *wal, i915_reg_t reg, u32 clr)
186 wa_write_clr_set(wal, reg, clr, 0);
190 * WA operations on "masked register". A masked register has the upper 16 bits
191 * documented as "masked" in b-spec. Its purpose is to allow writing to just a
192 * portion of the register without a rmw: you simply write in the upper 16 bits
193 * the mask of bits you are going to modify.
195 * The wa_masked_* family of functions already does the necessary operations to
196 * calculate the mask based on the parameters passed, so user only has to
197 * provide the lower 16 bits of that register.
201 wa_masked_en(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
203 wa_add(wal, reg, 0, _MASKED_BIT_ENABLE(val), val);
207 wa_masked_dis(struct i915_wa_list *wal, i915_reg_t reg, u32 val)
209 wa_add(wal, reg, 0, _MASKED_BIT_DISABLE(val), val);
213 wa_masked_field_set(struct i915_wa_list *wal, i915_reg_t reg,
216 wa_add(wal, reg, 0, _MASKED_FIELD(mask, val), mask);
219 static void gen6_ctx_workarounds_init(struct intel_engine_cs *engine,
220 struct i915_wa_list *wal)
222 wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
225 static void gen7_ctx_workarounds_init(struct intel_engine_cs *engine,
226 struct i915_wa_list *wal)
228 wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
231 static void gen8_ctx_workarounds_init(struct intel_engine_cs *engine,
232 struct i915_wa_list *wal)
234 wa_masked_en(wal, INSTPM, INSTPM_FORCE_ORDERING);
236 /* WaDisableAsyncFlipPerfMode:bdw,chv */
237 wa_masked_en(wal, MI_MODE, ASYNC_FLIP_PERF_DISABLE);
239 /* WaDisablePartialInstShootdown:bdw,chv */
240 wa_masked_en(wal, GEN8_ROW_CHICKEN,
241 PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
243 /* Use Force Non-Coherent whenever executing a 3D context. This is a
244 * workaround for a possible hang in the unlikely event a TLB
245 * invalidation occurs during a PSD flush.
247 /* WaForceEnableNonCoherent:bdw,chv */
248 /* WaHdcDisableFetchWhenMasked:bdw,chv */
249 wa_masked_en(wal, HDC_CHICKEN0,
250 HDC_DONOT_FETCH_MEM_WHEN_MASKED |
251 HDC_FORCE_NON_COHERENT);
253 /* From the Haswell PRM, Command Reference: Registers, CACHE_MODE_0:
254 * "The Hierarchical Z RAW Stall Optimization allows non-overlapping
255 * polygons in the same 8x4 pixel/sample area to be processed without
256 * stalling waiting for the earlier ones to write to Hierarchical Z
259 * This optimization is off by default for BDW and CHV; turn it on.
261 wa_masked_dis(wal, CACHE_MODE_0_GEN7, HIZ_RAW_STALL_OPT_DISABLE);
263 /* Wa4x4STCOptimizationDisable:bdw,chv */
264 wa_masked_en(wal, CACHE_MODE_1, GEN8_4x4_STC_OPTIMIZATION_DISABLE);
267 * BSpec recommends 8x4 when MSAA is used,
268 * however in practice 16x4 seems fastest.
270 * Note that PS/WM thread counts depend on the WIZ hashing
271 * disable bit, which we don't touch here, but it's good
272 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
274 wa_masked_field_set(wal, GEN7_GT_MODE,
275 GEN6_WIZ_HASHING_MASK,
276 GEN6_WIZ_HASHING_16x4);
279 static void bdw_ctx_workarounds_init(struct intel_engine_cs *engine,
280 struct i915_wa_list *wal)
282 struct drm_i915_private *i915 = engine->i915;
284 gen8_ctx_workarounds_init(engine, wal);
286 /* WaDisableThreadStallDopClockGating:bdw (pre-production) */
287 wa_masked_en(wal, GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
289 /* WaDisableDopClockGating:bdw
291 * Also see the related UCGTCL1 write in bdw_init_clock_gating()
292 * to disable EUTC clock gating.
294 wa_masked_en(wal, GEN7_ROW_CHICKEN2,
295 DOP_CLOCK_GATING_DISABLE);
297 wa_masked_en(wal, HALF_SLICE_CHICKEN3,
298 GEN8_SAMPLER_POWER_BYPASS_DIS);
300 wa_masked_en(wal, HDC_CHICKEN0,
301 /* WaForceContextSaveRestoreNonCoherent:bdw */
302 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
303 /* WaDisableFenceDestinationToSLM:bdw (pre-prod) */
304 (IS_BDW_GT3(i915) ? HDC_FENCE_DEST_SLM_DISABLE : 0));
307 static void chv_ctx_workarounds_init(struct intel_engine_cs *engine,
308 struct i915_wa_list *wal)
310 gen8_ctx_workarounds_init(engine, wal);
312 /* WaDisableThreadStallDopClockGating:chv */
313 wa_masked_en(wal, GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
315 /* Improve HiZ throughput on CHV. */
316 wa_masked_en(wal, HIZ_CHICKEN, CHV_HZ_8X8_MODE_IN_1X);
319 static void gen9_ctx_workarounds_init(struct intel_engine_cs *engine,
320 struct i915_wa_list *wal)
322 struct drm_i915_private *i915 = engine->i915;
325 /* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
327 * Must match Display Engine. See
328 * WaCompressedResourceDisplayNewHashMode.
330 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
331 GEN9_PBE_COMPRESSED_HASH_SELECTION);
332 wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
333 GEN9_SAMPLER_HASH_COMPRESSED_READ_ADDR);
336 /* WaClearFlowControlGpgpuContextSave:skl,bxt,kbl,glk,cfl */
337 /* WaDisablePartialInstShootdown:skl,bxt,kbl,glk,cfl */
338 wa_masked_en(wal, GEN8_ROW_CHICKEN,
339 FLOW_CONTROL_ENABLE |
340 PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE);
342 /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl,glk,cfl */
343 /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl,cfl */
344 wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
345 GEN9_ENABLE_YV12_BUGFIX |
346 GEN9_ENABLE_GPGPU_PREEMPTION);
348 /* Wa4x4STCOptimizationDisable:skl,bxt,kbl,glk,cfl */
349 /* WaDisablePartialResolveInVc:skl,bxt,kbl,cfl */
350 wa_masked_en(wal, CACHE_MODE_1,
351 GEN8_4x4_STC_OPTIMIZATION_DISABLE |
352 GEN9_PARTIAL_RESOLVE_IN_VC_DISABLE);
354 /* WaCcsTlbPrefetchDisable:skl,bxt,kbl,glk,cfl */
355 wa_masked_dis(wal, GEN9_HALF_SLICE_CHICKEN5,
356 GEN9_CCS_TLB_PREFETCH_ENABLE);
358 /* WaForceContextSaveRestoreNonCoherent:skl,bxt,kbl,cfl */
359 wa_masked_en(wal, HDC_CHICKEN0,
360 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT |
361 HDC_FORCE_CSR_NON_COHERENT_OVR_DISABLE);
363 /* WaForceEnableNonCoherent and WaDisableHDCInvalidation are
364 * both tied to WaForceContextSaveRestoreNonCoherent
365 * in some hsds for skl. We keep the tie for all gen9. The
366 * documentation is a bit hazy and so we want to get common behaviour,
367 * even though there is no clear evidence we would need both on kbl/bxt.
368 * This area has been source of system hangs so we play it safe
369 * and mimic the skl regardless of what bspec says.
371 * Use Force Non-Coherent whenever executing a 3D context. This
372 * is a workaround for a possible hang in the unlikely event
373 * a TLB invalidation occurs during a PSD flush.
376 /* WaForceEnableNonCoherent:skl,bxt,kbl,cfl */
377 wa_masked_en(wal, HDC_CHICKEN0,
378 HDC_FORCE_NON_COHERENT);
380 /* WaDisableSamplerPowerBypassForSOPingPong:skl,bxt,kbl,cfl */
381 if (IS_SKYLAKE(i915) ||
383 IS_COFFEELAKE(i915) ||
385 wa_masked_en(wal, HALF_SLICE_CHICKEN3,
386 GEN8_SAMPLER_POWER_BYPASS_DIS);
388 /* WaDisableSTUnitPowerOptimization:skl,bxt,kbl,glk,cfl */
389 wa_masked_en(wal, HALF_SLICE_CHICKEN2, GEN8_ST_PO_DISABLE);
392 * Supporting preemption with fine-granularity requires changes in the
393 * batch buffer programming. Since we can't break old userspace, we
394 * need to set our default preemption level to safe value. Userspace is
395 * still able to use more fine-grained preemption levels, since in
396 * WaEnablePreemptionGranularityControlByUMD we're whitelisting the
397 * per-ctx register. As such, WaDisable{3D,GPGPU}MidCmdPreemption are
398 * not real HW workarounds, but merely a way to start using preemption
399 * while maintaining old contract with userspace.
402 /* WaDisable3DMidCmdPreemption:skl,bxt,glk,cfl,[cnl] */
403 wa_masked_dis(wal, GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
405 /* WaDisableGPGPUMidCmdPreemption:skl,bxt,blk,cfl,[cnl] */
406 wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
407 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
408 GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);
410 /* WaClearHIZ_WM_CHICKEN3:bxt,glk */
411 if (IS_GEN9_LP(i915))
412 wa_masked_en(wal, GEN9_WM_CHICKEN3, GEN9_FACTOR_IN_CLR_VAL_HIZ);
415 static void skl_tune_iz_hashing(struct intel_engine_cs *engine,
416 struct i915_wa_list *wal)
418 struct intel_gt *gt = engine->gt;
419 u8 vals[3] = { 0, 0, 0 };
422 for (i = 0; i < 3; i++) {
426 * Only consider slices where one, and only one, subslice has 7
429 if (!is_power_of_2(gt->info.sseu.subslice_7eu[i]))
433 * subslice_7eu[i] != 0 (because of the check above) and
434 * ss_max == 4 (maximum number of subslices possible per slice)
438 ss = ffs(gt->info.sseu.subslice_7eu[i]) - 1;
442 if (vals[0] == 0 && vals[1] == 0 && vals[2] == 0)
445 /* Tune IZ hashing. See intel_device_info_runtime_init() */
446 wa_masked_field_set(wal, GEN7_GT_MODE,
447 GEN9_IZ_HASHING_MASK(2) |
448 GEN9_IZ_HASHING_MASK(1) |
449 GEN9_IZ_HASHING_MASK(0),
450 GEN9_IZ_HASHING(2, vals[2]) |
451 GEN9_IZ_HASHING(1, vals[1]) |
452 GEN9_IZ_HASHING(0, vals[0]));
455 static void skl_ctx_workarounds_init(struct intel_engine_cs *engine,
456 struct i915_wa_list *wal)
458 gen9_ctx_workarounds_init(engine, wal);
459 skl_tune_iz_hashing(engine, wal);
462 static void bxt_ctx_workarounds_init(struct intel_engine_cs *engine,
463 struct i915_wa_list *wal)
465 gen9_ctx_workarounds_init(engine, wal);
467 /* WaDisableThreadStallDopClockGating:bxt */
468 wa_masked_en(wal, GEN8_ROW_CHICKEN,
469 STALL_DOP_GATING_DISABLE);
471 /* WaToEnableHwFixForPushConstHWBug:bxt */
472 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
473 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
476 static void kbl_ctx_workarounds_init(struct intel_engine_cs *engine,
477 struct i915_wa_list *wal)
479 struct drm_i915_private *i915 = engine->i915;
481 gen9_ctx_workarounds_init(engine, wal);
483 /* WaToEnableHwFixForPushConstHWBug:kbl */
484 if (IS_KBL_GT_STEP(i915, STEP_C0, STEP_FOREVER))
485 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
486 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
488 /* WaDisableSbeCacheDispatchPortSharing:kbl */
489 wa_masked_en(wal, GEN7_HALF_SLICE_CHICKEN1,
490 GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
493 static void glk_ctx_workarounds_init(struct intel_engine_cs *engine,
494 struct i915_wa_list *wal)
496 gen9_ctx_workarounds_init(engine, wal);
498 /* WaToEnableHwFixForPushConstHWBug:glk */
499 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
500 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
503 static void cfl_ctx_workarounds_init(struct intel_engine_cs *engine,
504 struct i915_wa_list *wal)
506 gen9_ctx_workarounds_init(engine, wal);
508 /* WaToEnableHwFixForPushConstHWBug:cfl */
509 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
510 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
512 /* WaDisableSbeCacheDispatchPortSharing:cfl */
513 wa_masked_en(wal, GEN7_HALF_SLICE_CHICKEN1,
514 GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
517 static void cnl_ctx_workarounds_init(struct intel_engine_cs *engine,
518 struct i915_wa_list *wal)
520 /* WaForceContextSaveRestoreNonCoherent:cnl */
521 wa_masked_en(wal, CNL_HDC_CHICKEN0,
522 HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT);
524 /* WaDisableReplayBufferBankArbitrationOptimization:cnl */
525 wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
526 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
528 /* WaPushConstantDereferenceHoldDisable:cnl */
529 wa_masked_en(wal, GEN7_ROW_CHICKEN2, PUSH_CONSTANT_DEREF_DISABLE);
531 /* FtrEnableFastAnisoL1BankingFix:cnl */
532 wa_masked_en(wal, HALF_SLICE_CHICKEN3, CNL_FAST_ANISO_L1_BANKING_FIX);
534 /* WaDisable3DMidCmdPreemption:cnl */
535 wa_masked_dis(wal, GEN8_CS_CHICKEN1, GEN9_PREEMPT_3D_OBJECT_LEVEL);
537 /* WaDisableGPGPUMidCmdPreemption:cnl */
538 wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
539 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
540 GEN9_PREEMPT_GPGPU_COMMAND_LEVEL);
542 /* WaDisableEarlyEOT:cnl */
543 wa_masked_en(wal, GEN8_ROW_CHICKEN, DISABLE_EARLY_EOT);
546 static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
547 struct i915_wa_list *wal)
549 struct drm_i915_private *i915 = engine->i915;
551 /* WaDisableBankHangMode:icl */
554 intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
557 /* Wa_1604370585:icl (pre-prod)
558 * Formerly known as WaPushConstantDereferenceHoldDisable
560 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
561 wa_masked_en(wal, GEN7_ROW_CHICKEN2,
562 PUSH_CONSTANT_DEREF_DISABLE);
564 /* WaForceEnableNonCoherent:icl
565 * This is not the same workaround as in early Gen9 platforms, where
566 * lacking this could cause system hangs, but coherency performance
567 * overhead is high and only a few compute workloads really need it
568 * (the register is whitelisted in hardware now, so UMDs can opt in
569 * for coherency if they have a good reason).
571 wa_masked_en(wal, ICL_HDC_MODE, HDC_FORCE_NON_COHERENT);
573 /* Wa_2006611047:icl (pre-prod)
574 * Formerly known as WaDisableImprovedTdlClkGating
576 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
577 wa_masked_en(wal, GEN7_ROW_CHICKEN2,
578 GEN11_TDL_CLOCK_GATING_FIX_DISABLE);
580 /* Wa_2006665173:icl (pre-prod) */
581 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
582 wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3,
583 GEN11_BLEND_EMB_FIX_DISABLE_IN_RCC);
585 /* WaEnableFloatBlendOptimization:icl */
586 wa_write_clr_set(wal,
588 0, /* write-only, so skip validation */
589 _MASKED_BIT_ENABLE(FLOAT_BLEND_OPTIMIZATION_ENABLE));
591 /* WaDisableGPGPUMidThreadPreemption:icl */
592 wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
593 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
594 GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
596 /* allow headerless messages for preemptible GPGPU context */
597 wa_masked_en(wal, GEN10_SAMPLER_MODE,
598 GEN11_SAMPLER_ENABLE_HEADLESS_MSG);
600 /* Wa_1604278689:icl,ehl */
601 wa_write(wal, IVB_FBC_RT_BASE, 0xFFFFFFFF & ~ILK_FBC_RT_VALID);
602 wa_write_clr_set(wal, IVB_FBC_RT_BASE_UPPER,
603 0, /* write-only register; skip validation */
606 /* Wa_1406306137:icl,ehl */
607 wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN11_DIS_PICK_2ND_EU);
611 * These settings aren't actually workarounds, but general tuning settings that
612 * need to be programmed on several platforms.
614 static void gen12_ctx_gt_tuning_init(struct intel_engine_cs *engine,
615 struct i915_wa_list *wal)
618 * Although some platforms refer to it as Wa_1604555607, we need to
619 * program it even on those that don't explicitly list that
622 * Note that the programming of this register is further modified
623 * according to the FF_MODE2 guidance given by Wa_1608008084:gen12.
624 * Wa_1608008084 tells us the FF_MODE2 register will return the wrong
625 * value when read. The default value for this register is zero for all
626 * fields and there are no bit masks. So instead of doing a RMW we
627 * should just write TDS timer value. For the same reason read
628 * verification is ignored.
632 FF_MODE2_TDS_TIMER_MASK,
633 FF_MODE2_TDS_TIMER_128,
637 static void gen12_ctx_workarounds_init(struct intel_engine_cs *engine,
638 struct i915_wa_list *wal)
640 gen12_ctx_gt_tuning_init(engine, wal);
643 * Wa_1409142259:tgl,dg1,adl-p
644 * Wa_1409347922:tgl,dg1,adl-p
645 * Wa_1409252684:tgl,dg1,adl-p
646 * Wa_1409217633:tgl,dg1,adl-p
647 * Wa_1409207793:tgl,dg1,adl-p
648 * Wa_1409178076:tgl,dg1,adl-p
649 * Wa_1408979724:tgl,dg1,adl-p
650 * Wa_14010443199:tgl,rkl,dg1,adl-p
651 * Wa_14010698770:tgl,rkl,dg1,adl-s,adl-p
652 * Wa_1409342910:tgl,rkl,dg1,adl-s,adl-p
654 wa_masked_en(wal, GEN11_COMMON_SLICE_CHICKEN3,
655 GEN12_DISABLE_CPS_AWARE_COLOR_PIPE);
657 /* WaDisableGPGPUMidThreadPreemption:gen12 */
658 wa_masked_field_set(wal, GEN8_CS_CHICKEN1,
659 GEN9_PREEMPT_GPGPU_LEVEL_MASK,
660 GEN9_PREEMPT_GPGPU_THREAD_GROUP_LEVEL);
665 * Like in gen12_ctx_gt_tuning_init(), read verification is ignored due
670 FF_MODE2_GS_TIMER_MASK,
671 FF_MODE2_GS_TIMER_224,
675 static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
676 struct i915_wa_list *wal)
678 gen12_ctx_workarounds_init(engine, wal);
681 wa_masked_dis(wal, GEN11_COMMON_SLICE_CHICKEN3,
682 DG1_FLOAT_POINT_BLEND_OPT_STRICT_MODE_EN);
685 wa_masked_en(wal, HIZ_CHICKEN,
686 DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
690 __intel_engine_init_ctx_wa(struct intel_engine_cs *engine,
691 struct i915_wa_list *wal,
694 struct drm_i915_private *i915 = engine->i915;
696 if (engine->class != RENDER_CLASS)
699 wa_init_start(wal, name, engine->name);
702 dg1_ctx_workarounds_init(engine, wal);
703 else if (GRAPHICS_VER(i915) == 12)
704 gen12_ctx_workarounds_init(engine, wal);
705 else if (GRAPHICS_VER(i915) == 11)
706 icl_ctx_workarounds_init(engine, wal);
707 else if (IS_CANNONLAKE(i915))
708 cnl_ctx_workarounds_init(engine, wal);
709 else if (IS_COFFEELAKE(i915) || IS_COMETLAKE(i915))
710 cfl_ctx_workarounds_init(engine, wal);
711 else if (IS_GEMINILAKE(i915))
712 glk_ctx_workarounds_init(engine, wal);
713 else if (IS_KABYLAKE(i915))
714 kbl_ctx_workarounds_init(engine, wal);
715 else if (IS_BROXTON(i915))
716 bxt_ctx_workarounds_init(engine, wal);
717 else if (IS_SKYLAKE(i915))
718 skl_ctx_workarounds_init(engine, wal);
719 else if (IS_CHERRYVIEW(i915))
720 chv_ctx_workarounds_init(engine, wal);
721 else if (IS_BROADWELL(i915))
722 bdw_ctx_workarounds_init(engine, wal);
723 else if (GRAPHICS_VER(i915) == 7)
724 gen7_ctx_workarounds_init(engine, wal);
725 else if (GRAPHICS_VER(i915) == 6)
726 gen6_ctx_workarounds_init(engine, wal);
727 else if (GRAPHICS_VER(i915) < 8)
730 MISSING_CASE(GRAPHICS_VER(i915));
735 void intel_engine_init_ctx_wa(struct intel_engine_cs *engine)
737 __intel_engine_init_ctx_wa(engine, &engine->ctx_wa_list, "context");
740 int intel_engine_emit_ctx_wa(struct i915_request *rq)
742 struct i915_wa_list *wal = &rq->engine->ctx_wa_list;
751 ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
755 cs = intel_ring_begin(rq, (wal->count * 2 + 2));
759 *cs++ = MI_LOAD_REGISTER_IMM(wal->count);
760 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
761 *cs++ = i915_mmio_reg_offset(wa->reg);
766 intel_ring_advance(rq, cs);
768 ret = rq->engine->emit_flush(rq, EMIT_BARRIER);
776 gen4_gt_workarounds_init(struct drm_i915_private *i915,
777 struct i915_wa_list *wal)
779 /* WaDisable_RenderCache_OperationalFlush:gen4,ilk */
780 wa_masked_dis(wal, CACHE_MODE_0, RC_OP_FLUSH_ENABLE);
784 g4x_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
786 gen4_gt_workarounds_init(i915, wal);
788 /* WaDisableRenderCachePipelinedFlush:g4x,ilk */
789 wa_masked_en(wal, CACHE_MODE_0, CM0_PIPELINED_RENDER_FLUSH_DISABLE);
793 ilk_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
795 g4x_gt_workarounds_init(i915, wal);
797 wa_masked_en(wal, _3D_CHICKEN2, _3D_CHICKEN2_WM_READ_PIPELINED);
801 snb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
806 ivb_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
808 /* Apply the WaDisableRHWOOptimizationForRenderHang:ivb workaround. */
810 GEN7_COMMON_SLICE_CHICKEN1,
811 GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC);
813 /* WaApplyL3ControlAndL3ChickenMode:ivb */
814 wa_write(wal, GEN7_L3CNTLREG1, GEN7_WA_FOR_GEN7_L3_CONTROL);
815 wa_write(wal, GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE);
817 /* WaForceL3Serialization:ivb */
818 wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);
822 vlv_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
824 /* WaForceL3Serialization:vlv */
825 wa_write_clr(wal, GEN7_L3SQCREG4, L3SQ_URB_READ_CAM_MATCH_DISABLE);
828 * WaIncreaseL3CreditsForVLVB0:vlv
829 * This is the hardware default actually.
831 wa_write(wal, GEN7_L3SQCREG1, VLV_B0_WA_L3SQCREG1_VALUE);
835 hsw_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
837 /* L3 caching of data atomics doesn't work -- disable it. */
838 wa_write(wal, HSW_SCRATCH1, HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE);
842 _MASKED_BIT_ENABLE(HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE),
843 0 /* XXX does this reg exist? */);
845 /* WaVSRefCountFullforceMissDisable:hsw */
846 wa_write_clr(wal, GEN7_FF_THREAD_MODE, GEN7_FF_VS_REF_CNT_FFME);
850 gen9_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
852 /* WaDisableKillLogic:bxt,skl,kbl */
853 if (!IS_COFFEELAKE(i915) && !IS_COMETLAKE(i915))
859 /* WaCompressedResourceSamplerPbeMediaNewHashMode:skl,kbl
861 * Must match Display Engine. See
862 * WaCompressedResourceDisplayNewHashMode.
866 MMCD_PCLA | MMCD_HOTSPOT_EN);
869 /* WaDisableHDCInvalidation:skl,bxt,kbl,cfl */
872 BDW_DISABLE_HDC_INVALIDATION);
876 skl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
878 gen9_gt_workarounds_init(i915, wal);
880 /* WaDisableGafsUnitClkGating:skl */
883 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
885 /* WaInPlaceDecompressionHang:skl */
886 if (IS_SKL_REVID(i915, SKL_REVID_H0, REVID_FOREVER))
888 GEN9_GAMT_ECO_REG_RW_IA,
889 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
893 bxt_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
895 gen9_gt_workarounds_init(i915, wal);
897 /* WaInPlaceDecompressionHang:bxt */
899 GEN9_GAMT_ECO_REG_RW_IA,
900 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
904 kbl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
906 gen9_gt_workarounds_init(i915, wal);
908 /* WaDisableDynamicCreditSharing:kbl */
909 if (IS_KBL_GT_STEP(i915, 0, STEP_B0))
912 GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
914 /* WaDisableGafsUnitClkGating:kbl */
917 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
919 /* WaInPlaceDecompressionHang:kbl */
921 GEN9_GAMT_ECO_REG_RW_IA,
922 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
926 glk_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
928 gen9_gt_workarounds_init(i915, wal);
932 cfl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
934 gen9_gt_workarounds_init(i915, wal);
936 /* WaDisableGafsUnitClkGating:cfl */
939 GEN8_EU_GAUNIT_CLOCK_GATE_DISABLE);
941 /* WaInPlaceDecompressionHang:cfl */
943 GEN9_GAMT_ECO_REG_RW_IA,
944 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
948 icl_wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
950 const struct sseu_dev_info *sseu = &i915->gt.info.sseu;
951 unsigned int slice, subslice;
954 GEM_BUG_ON(GRAPHICS_VER(i915) < 11);
955 GEM_BUG_ON(hweight8(sseu->slice_mask) > 1);
959 * Although a platform may have subslices, we need to always steer
960 * reads to the lowest instance that isn't fused off. When Render
961 * Power Gating is enabled, grabbing forcewake will only power up a
962 * single subslice (the "minconfig") if there isn't a real workload
963 * that needs to be run; this means that if we steer register reads to
964 * one of the higher subslices, we run the risk of reading back 0's or
967 subslice = __ffs(intel_sseu_get_subslices(sseu, slice));
970 * If the subslice we picked above also steers us to a valid L3 bank,
971 * then we can just rely on the default steering and won't need to
972 * worry about explicitly re-steering L3BANK reads later.
974 if (i915->gt.info.l3bank_mask & BIT(subslice))
975 i915->gt.steering_table[L3BANK] = NULL;
977 mcr = GEN11_MCR_SLICE(slice) | GEN11_MCR_SUBSLICE(subslice);
978 mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
980 drm_dbg(&i915->drm, "MCR slice/subslice = %x\n", mcr);
982 wa_write_clr_set(wal, GEN8_MCR_SELECTOR, mcr_mask, mcr);
986 cnl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
988 /* WaInPlaceDecompressionHang:cnl */
990 GEN9_GAMT_ECO_REG_RW_IA,
991 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
995 icl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
997 icl_wa_init_mcr(i915, wal);
999 /* WaInPlaceDecompressionHang:icl */
1001 GEN9_GAMT_ECO_REG_RW_IA,
1002 GAMT_ECO_ENABLE_IN_PLACE_DECOMPRESS);
1004 /* WaModifyGamTlbPartitioning:icl */
1005 wa_write_clr_set(wal,
1006 GEN11_GACB_PERF_CTRL,
1007 GEN11_HASH_CTRL_MASK,
1008 GEN11_HASH_CTRL_BIT0 | GEN11_HASH_CTRL_BIT4);
1010 /* Wa_1405766107:icl
1011 * Formerly known as WaCL2SFHalfMaxAlloc
1015 GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC |
1016 GEN11_LSN_UNSLCVC_GAFS_HALF_CL2_MAXALLOC);
1019 * Formerly known as WaDisCtxReload
1022 GEN8_GAMW_ECO_DEV_RW_IA,
1023 GAMW_ECO_DEV_CTX_RELOAD_DISABLE);
1025 /* Wa_1405779004:icl (pre-prod) */
1026 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_A0))
1028 SLICE_UNIT_LEVEL_CLKGATE,
1029 MSCUNIT_CLKGATE_DIS);
1031 /* Wa_1406838659:icl (pre-prod) */
1032 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
1034 INF_UNIT_LEVEL_CLKGATE,
1037 /* Wa_1406463099:icl
1038 * Formerly known as WaGamTlbPendError
1042 GAMT_CHKN_DISABLE_L3_COH_PIPE);
1044 /* Wa_1607087056:icl,ehl,jsl */
1045 if (IS_ICELAKE(i915) ||
1046 IS_JSL_EHL_REVID(i915, EHL_REVID_A0, EHL_REVID_A0))
1048 SLICE_UNIT_LEVEL_CLKGATE,
1049 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1053 * Though there are per-engine instances of these registers,
1054 * they retain their value through engine resets and should
1055 * only be provided on the GT workaround list rather than
1056 * the engine-specific workaround list.
1059 wa_14011060649(struct drm_i915_private *i915, struct i915_wa_list *wal)
1061 struct intel_engine_cs *engine;
1062 struct intel_gt *gt = &i915->gt;
1065 for_each_engine(engine, gt, id) {
1066 if (engine->class != VIDEO_DECODE_CLASS ||
1067 (engine->instance % 2))
1070 wa_write_or(wal, VDBOX_CGCTL3F10(engine->mmio_base),
1071 IECPUNIT_CLKGATE_DIS);
1076 gen12_gt_workarounds_init(struct drm_i915_private *i915,
1077 struct i915_wa_list *wal)
1079 icl_wa_init_mcr(i915, wal);
1081 /* Wa_14011060649:tgl,rkl,dg1,adls,adl-p */
1082 wa_14011060649(i915, wal);
1086 tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1088 gen12_gt_workarounds_init(i915, wal);
1090 /* Wa_1409420604:tgl */
1091 if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_A0))
1093 SUBSLICE_UNIT_LEVEL_CLKGATE2,
1094 CPSSUNIT_CLKGATE_DIS);
1096 /* Wa_1607087056:tgl also know as BUG:1409180338 */
1097 if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_A0))
1099 SLICE_UNIT_LEVEL_CLKGATE,
1100 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1102 /* Wa_1408615072:tgl[a0] */
1103 if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_A0))
1104 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1105 VSUNIT_CLKGATE_DIS_TGL);
1109 dg1_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
1111 gen12_gt_workarounds_init(i915, wal);
1113 /* Wa_1607087056:dg1 */
1114 if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0))
1116 SLICE_UNIT_LEVEL_CLKGATE,
1117 L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
1119 /* Wa_1409420604:dg1 */
1122 SUBSLICE_UNIT_LEVEL_CLKGATE2,
1123 CPSSUNIT_CLKGATE_DIS);
1125 /* Wa_1408615072:dg1 */
1126 /* Empirical testing shows this register is unaffected by engine reset. */
1128 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1129 VSUNIT_CLKGATE_DIS_TGL);
1133 gt_init_workarounds(struct drm_i915_private *i915, struct i915_wa_list *wal)
1136 dg1_gt_workarounds_init(i915, wal);
1137 else if (IS_TIGERLAKE(i915))
1138 tgl_gt_workarounds_init(i915, wal);
1139 else if (GRAPHICS_VER(i915) == 12)
1140 gen12_gt_workarounds_init(i915, wal);
1141 else if (GRAPHICS_VER(i915) == 11)
1142 icl_gt_workarounds_init(i915, wal);
1143 else if (IS_CANNONLAKE(i915))
1144 cnl_gt_workarounds_init(i915, wal);
1145 else if (IS_COFFEELAKE(i915) || IS_COMETLAKE(i915))
1146 cfl_gt_workarounds_init(i915, wal);
1147 else if (IS_GEMINILAKE(i915))
1148 glk_gt_workarounds_init(i915, wal);
1149 else if (IS_KABYLAKE(i915))
1150 kbl_gt_workarounds_init(i915, wal);
1151 else if (IS_BROXTON(i915))
1152 bxt_gt_workarounds_init(i915, wal);
1153 else if (IS_SKYLAKE(i915))
1154 skl_gt_workarounds_init(i915, wal);
1155 else if (IS_HASWELL(i915))
1156 hsw_gt_workarounds_init(i915, wal);
1157 else if (IS_VALLEYVIEW(i915))
1158 vlv_gt_workarounds_init(i915, wal);
1159 else if (IS_IVYBRIDGE(i915))
1160 ivb_gt_workarounds_init(i915, wal);
1161 else if (GRAPHICS_VER(i915) == 6)
1162 snb_gt_workarounds_init(i915, wal);
1163 else if (GRAPHICS_VER(i915) == 5)
1164 ilk_gt_workarounds_init(i915, wal);
1165 else if (IS_G4X(i915))
1166 g4x_gt_workarounds_init(i915, wal);
1167 else if (GRAPHICS_VER(i915) == 4)
1168 gen4_gt_workarounds_init(i915, wal);
1169 else if (GRAPHICS_VER(i915) <= 8)
1172 MISSING_CASE(GRAPHICS_VER(i915));
1175 void intel_gt_init_workarounds(struct drm_i915_private *i915)
1177 struct i915_wa_list *wal = &i915->gt_wa_list;
1179 wa_init_start(wal, "GT", "global");
1180 gt_init_workarounds(i915, wal);
1181 wa_init_finish(wal);
1184 static enum forcewake_domains
1185 wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)
1187 enum forcewake_domains fw = 0;
1191 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1192 fw |= intel_uncore_forcewake_for_reg(uncore,
1201 wa_verify(const struct i915_wa *wa, u32 cur, const char *name, const char *from)
1203 if ((cur ^ wa->set) & wa->read) {
1204 DRM_ERROR("%s workaround lost on %s! (reg[%x]=0x%x, relevant bits were 0x%x vs expected 0x%x)\n",
1205 name, from, i915_mmio_reg_offset(wa->reg),
1206 cur, cur & wa->read, wa->set & wa->read);
1215 wa_list_apply(struct intel_gt *gt, const struct i915_wa_list *wal)
1217 struct intel_uncore *uncore = gt->uncore;
1218 enum forcewake_domains fw;
1219 unsigned long flags;
1226 fw = wal_get_fw_for_rmw(uncore, wal);
1228 spin_lock_irqsave(&uncore->lock, flags);
1229 intel_uncore_forcewake_get__locked(uncore, fw);
1231 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
1234 /* open-coded rmw due to steering */
1235 old = wa->clr ? intel_gt_read_register_fw(gt, wa->reg) : 0;
1236 val = (old & ~wa->clr) | wa->set;
1237 if (val != old || !wa->clr)
1238 intel_uncore_write_fw(uncore, wa->reg, val);
1240 if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
1241 wa_verify(wa, intel_gt_read_register_fw(gt, wa->reg),
1242 wal->name, "application");
1245 intel_uncore_forcewake_put__locked(uncore, fw);
1246 spin_unlock_irqrestore(&uncore->lock, flags);
1249 void intel_gt_apply_workarounds(struct intel_gt *gt)
1251 wa_list_apply(gt, >->i915->gt_wa_list);
1254 static bool wa_list_verify(struct intel_gt *gt,
1255 const struct i915_wa_list *wal,
1258 struct intel_uncore *uncore = gt->uncore;
1260 enum forcewake_domains fw;
1261 unsigned long flags;
1265 fw = wal_get_fw_for_rmw(uncore, wal);
1267 spin_lock_irqsave(&uncore->lock, flags);
1268 intel_uncore_forcewake_get__locked(uncore, fw);
1270 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1272 intel_gt_read_register_fw(gt, wa->reg),
1275 intel_uncore_forcewake_put__locked(uncore, fw);
1276 spin_unlock_irqrestore(&uncore->lock, flags);
1281 bool intel_gt_verify_workarounds(struct intel_gt *gt, const char *from)
1283 return wa_list_verify(gt, >->i915->gt_wa_list, from);
1287 static bool is_nonpriv_flags_valid(u32 flags)
1289 /* Check only valid flag bits are set */
1290 if (flags & ~RING_FORCE_TO_NONPRIV_MASK_VALID)
1293 /* NB: Only 3 out of 4 enum values are valid for access field */
1294 if ((flags & RING_FORCE_TO_NONPRIV_ACCESS_MASK) ==
1295 RING_FORCE_TO_NONPRIV_ACCESS_INVALID)
1302 whitelist_reg_ext(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)
1304 struct i915_wa wa = {
1308 if (GEM_DEBUG_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
1311 if (GEM_DEBUG_WARN_ON(!is_nonpriv_flags_valid(flags)))
1314 wa.reg.reg |= flags;
1319 whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
1321 whitelist_reg_ext(wal, reg, RING_FORCE_TO_NONPRIV_ACCESS_RW);
1324 static void gen9_whitelist_build(struct i915_wa_list *w)
1326 /* WaVFEStateAfterPipeControlwithMediaStateClear:skl,bxt,glk,cfl */
1327 whitelist_reg(w, GEN9_CTX_PREEMPT_REG);
1329 /* WaEnablePreemptionGranularityControlByUMD:skl,bxt,kbl,cfl,[cnl] */
1330 whitelist_reg(w, GEN8_CS_CHICKEN1);
1332 /* WaAllowUMDToModifyHDCChicken1:skl,bxt,kbl,glk,cfl */
1333 whitelist_reg(w, GEN8_HDC_CHICKEN1);
1335 /* WaSendPushConstantsFromMMIO:skl,bxt */
1336 whitelist_reg(w, COMMON_SLICE_CHICKEN2);
1339 static void skl_whitelist_build(struct intel_engine_cs *engine)
1341 struct i915_wa_list *w = &engine->whitelist;
1343 if (engine->class != RENDER_CLASS)
1346 gen9_whitelist_build(w);
1348 /* WaDisableLSQCROPERFforOCL:skl */
1349 whitelist_reg(w, GEN8_L3SQCREG4);
1352 static void bxt_whitelist_build(struct intel_engine_cs *engine)
1354 if (engine->class != RENDER_CLASS)
1357 gen9_whitelist_build(&engine->whitelist);
1360 static void kbl_whitelist_build(struct intel_engine_cs *engine)
1362 struct i915_wa_list *w = &engine->whitelist;
1364 if (engine->class != RENDER_CLASS)
1367 gen9_whitelist_build(w);
1369 /* WaDisableLSQCROPERFforOCL:kbl */
1370 whitelist_reg(w, GEN8_L3SQCREG4);
1373 static void glk_whitelist_build(struct intel_engine_cs *engine)
1375 struct i915_wa_list *w = &engine->whitelist;
1377 if (engine->class != RENDER_CLASS)
1380 gen9_whitelist_build(w);
1382 /* WA #0862: Userspace has to set "Barrier Mode" to avoid hangs. */
1383 whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1386 static void cfl_whitelist_build(struct intel_engine_cs *engine)
1388 struct i915_wa_list *w = &engine->whitelist;
1390 if (engine->class != RENDER_CLASS)
1393 gen9_whitelist_build(w);
1396 * WaAllowPMDepthAndInvocationCountAccessFromUMD:cfl,whl,cml,aml
1398 * This covers 4 register which are next to one another :
1399 * - PS_INVOCATION_COUNT
1400 * - PS_INVOCATION_COUNT_UDW
1402 * - PS_DEPTH_COUNT_UDW
1404 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1405 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1406 RING_FORCE_TO_NONPRIV_RANGE_4);
1409 static void cml_whitelist_build(struct intel_engine_cs *engine)
1411 struct i915_wa_list *w = &engine->whitelist;
1413 if (engine->class != RENDER_CLASS)
1414 whitelist_reg_ext(w,
1415 RING_CTX_TIMESTAMP(engine->mmio_base),
1416 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1418 cfl_whitelist_build(engine);
1421 static void cnl_whitelist_build(struct intel_engine_cs *engine)
1423 struct i915_wa_list *w = &engine->whitelist;
1425 if (engine->class != RENDER_CLASS)
1428 /* WaEnablePreemptionGranularityControlByUMD:cnl */
1429 whitelist_reg(w, GEN8_CS_CHICKEN1);
1432 static void icl_whitelist_build(struct intel_engine_cs *engine)
1434 struct i915_wa_list *w = &engine->whitelist;
1436 switch (engine->class) {
1438 /* WaAllowUMDToModifyHalfSliceChicken7:icl */
1439 whitelist_reg(w, GEN9_HALF_SLICE_CHICKEN7);
1441 /* WaAllowUMDToModifySamplerMode:icl */
1442 whitelist_reg(w, GEN10_SAMPLER_MODE);
1444 /* WaEnableStateCacheRedirectToCS:icl */
1445 whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
1448 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
1450 * This covers 4 register which are next to one another :
1451 * - PS_INVOCATION_COUNT
1452 * - PS_INVOCATION_COUNT_UDW
1454 * - PS_DEPTH_COUNT_UDW
1456 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1457 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1458 RING_FORCE_TO_NONPRIV_RANGE_4);
1461 case VIDEO_DECODE_CLASS:
1462 /* hucStatusRegOffset */
1463 whitelist_reg_ext(w, _MMIO(0x2000 + engine->mmio_base),
1464 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1465 /* hucUKernelHdrInfoRegOffset */
1466 whitelist_reg_ext(w, _MMIO(0x2014 + engine->mmio_base),
1467 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1468 /* hucStatus2RegOffset */
1469 whitelist_reg_ext(w, _MMIO(0x23B0 + engine->mmio_base),
1470 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1471 whitelist_reg_ext(w,
1472 RING_CTX_TIMESTAMP(engine->mmio_base),
1473 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1477 whitelist_reg_ext(w,
1478 RING_CTX_TIMESTAMP(engine->mmio_base),
1479 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1484 static void tgl_whitelist_build(struct intel_engine_cs *engine)
1486 struct i915_wa_list *w = &engine->whitelist;
1488 switch (engine->class) {
1491 * WaAllowPMDepthAndInvocationCountAccessFromUMD:tgl
1494 * This covers 4 registers which are next to one another :
1495 * - PS_INVOCATION_COUNT
1496 * - PS_INVOCATION_COUNT_UDW
1498 * - PS_DEPTH_COUNT_UDW
1500 whitelist_reg_ext(w, PS_INVOCATION_COUNT,
1501 RING_FORCE_TO_NONPRIV_ACCESS_RD |
1502 RING_FORCE_TO_NONPRIV_RANGE_4);
1504 /* Wa_1808121037:tgl */
1505 whitelist_reg(w, GEN7_COMMON_SLICE_CHICKEN1);
1507 /* Wa_1806527549:tgl */
1508 whitelist_reg(w, HIZ_CHICKEN);
1511 whitelist_reg_ext(w,
1512 RING_CTX_TIMESTAMP(engine->mmio_base),
1513 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1518 static void dg1_whitelist_build(struct intel_engine_cs *engine)
1520 struct i915_wa_list *w = &engine->whitelist;
1522 tgl_whitelist_build(engine);
1524 /* GEN:BUG:1409280441:dg1 */
1525 if (IS_DG1_REVID(engine->i915, DG1_REVID_A0, DG1_REVID_A0) &&
1526 (engine->class == RENDER_CLASS ||
1527 engine->class == COPY_ENGINE_CLASS))
1528 whitelist_reg_ext(w, RING_ID(engine->mmio_base),
1529 RING_FORCE_TO_NONPRIV_ACCESS_RD);
1532 void intel_engine_init_whitelist(struct intel_engine_cs *engine)
1534 struct drm_i915_private *i915 = engine->i915;
1535 struct i915_wa_list *w = &engine->whitelist;
1537 wa_init_start(w, "whitelist", engine->name);
1540 dg1_whitelist_build(engine);
1541 else if (GRAPHICS_VER(i915) == 12)
1542 tgl_whitelist_build(engine);
1543 else if (GRAPHICS_VER(i915) == 11)
1544 icl_whitelist_build(engine);
1545 else if (IS_CANNONLAKE(i915))
1546 cnl_whitelist_build(engine);
1547 else if (IS_COMETLAKE(i915))
1548 cml_whitelist_build(engine);
1549 else if (IS_COFFEELAKE(i915))
1550 cfl_whitelist_build(engine);
1551 else if (IS_GEMINILAKE(i915))
1552 glk_whitelist_build(engine);
1553 else if (IS_KABYLAKE(i915))
1554 kbl_whitelist_build(engine);
1555 else if (IS_BROXTON(i915))
1556 bxt_whitelist_build(engine);
1557 else if (IS_SKYLAKE(i915))
1558 skl_whitelist_build(engine);
1559 else if (GRAPHICS_VER(i915) <= 8)
1562 MISSING_CASE(GRAPHICS_VER(i915));
1567 void intel_engine_apply_whitelist(struct intel_engine_cs *engine)
1569 const struct i915_wa_list *wal = &engine->whitelist;
1570 struct intel_uncore *uncore = engine->uncore;
1571 const u32 base = engine->mmio_base;
1578 for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
1579 intel_uncore_write(uncore,
1580 RING_FORCE_TO_NONPRIV(base, i),
1581 i915_mmio_reg_offset(wa->reg));
1583 /* And clear the rest just in case of garbage */
1584 for (; i < RING_MAX_NONPRIV_SLOTS; i++)
1585 intel_uncore_write(uncore,
1586 RING_FORCE_TO_NONPRIV(base, i),
1587 i915_mmio_reg_offset(RING_NOPID(base)));
1591 rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
1593 struct drm_i915_private *i915 = engine->i915;
1595 if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
1596 IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_A0)) {
1598 * Wa_1607138336:tgl[a0],dg1[a0]
1599 * Wa_1607063988:tgl[a0],dg1[a0]
1602 GEN9_CTX_PREEMPT_REG,
1603 GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
1606 if (IS_TGL_UY_GT_STEP(i915, STEP_A0, STEP_A0)) {
1609 * (see also Wa_1606682166:icl)
1613 GEN7_DISABLE_SAMPLER_PREFETCH);
1616 if (IS_ALDERLAKE_P(i915) || IS_ALDERLAKE_S(i915) || IS_DG1(i915) ||
1617 IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1618 /* Wa_1606931601:tgl,rkl,dg1,adl-s,adl-p */
1619 wa_masked_en(wal, GEN7_ROW_CHICKEN2, GEN12_DISABLE_EARLY_READ);
1622 * Wa_1407928979:tgl A*
1623 * Wa_18011464164:tgl[B0+],dg1[B0+]
1624 * Wa_22010931296:tgl[B0+],dg1[B0+]
1625 * Wa_14010919138:rkl,dg1,adl-s,adl-p
1627 wa_write_or(wal, GEN7_FF_THREAD_MODE,
1628 GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
1631 * Wa_1606700617:tgl,dg1,adl-p
1632 * Wa_22010271021:tgl,rkl,dg1,adl-s,adl-p
1633 * Wa_14010826681:tgl,dg1,rkl,adl-p
1636 GEN9_CS_DEBUG_MODE1,
1637 FF_DOP_CLOCK_GATE_DISABLE);
1640 if (IS_ALDERLAKE_P(i915) || IS_ALDERLAKE_S(i915) ||
1641 IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
1642 IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1643 /* Wa_1409804808:tgl,rkl,dg1[a0],adl-s,adl-p */
1644 wa_masked_en(wal, GEN7_ROW_CHICKEN2,
1645 GEN12_PUSH_CONST_DEREF_HOLD_DIS);
1649 * Wa_14010229206:tgl,rkl,dg1[a0],adl-s,adl-p
1651 wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
1655 if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
1656 IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1660 * Wa_1607297627:tgl,rkl,dg1[a0]
1662 * On TGL and RKL there are multiple entries for this WA in the
1663 * BSpec; some indicate this is an A0-only WA, others indicate
1664 * it applies to all steppings so we trust the "all steppings."
1665 * For DG1 this only applies to A0.
1668 GEN6_RC_SLEEP_PSMI_CONTROL,
1669 GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
1670 GEN8_RC_SEMA_IDLE_MSG_DISABLE);
1673 if (IS_DG1(i915) || IS_ROCKETLAKE(i915) || IS_TIGERLAKE(i915)) {
1674 /* Wa_1406941453:tgl,rkl,dg1 */
1680 if (GRAPHICS_VER(i915) == 11) {
1681 /* This is not an Wa. Enable for better image quality */
1684 _3D_CHICKEN3_AA_LINE_QUALITY_FIX_ENABLE);
1686 /* WaPipelineFlushCoherentLines:icl */
1689 GEN8_LQSC_FLUSH_COHERENT_LINES);
1693 * Formerly known as WaGAPZPriorityScheme
1697 GEN11_ARBITRATION_PRIO_ORDER_MASK);
1701 * Formerly known as WaL3BankAddressHashing
1703 wa_write_clr_set(wal,
1705 GEN11_HASH_CTRL_EXCL_MASK,
1706 GEN11_HASH_CTRL_EXCL_BIT0);
1707 wa_write_clr_set(wal,
1709 GEN11_BANK_HASH_ADDR_EXCL_MASK,
1710 GEN11_BANK_HASH_ADDR_EXCL_BIT0);
1714 * Formerly known as WaDisableCleanEvicts
1718 GEN11_LQSC_CLEAN_EVICT_DISABLE);
1720 /* WaForwardProgressSoftReset:icl */
1722 GEN10_SCRATCH_LNCF2,
1723 PMFLUSHDONE_LNICRSDROP |
1724 PMFLUSH_GAPL3UNBLOCK |
1725 PMFLUSHDONE_LNEBLK);
1727 /* Wa_1406609255:icl (pre-prod) */
1728 if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
1731 GEN7_DISABLE_DEMAND_PREFETCH);
1733 /* Wa_1606682166:icl */
1736 GEN7_DISABLE_SAMPLER_PREFETCH);
1738 /* Wa_1409178092:icl */
1739 wa_write_clr_set(wal,
1741 GEN11_COHERENT_PARTIAL_WRITE_MERGE_ENABLE,
1744 /* WaEnable32PlaneMode:icl */
1745 wa_masked_en(wal, GEN9_CSFE_CHICKEN1_RCS,
1746 GEN11_ENABLE_32_PLANE_MODE);
1749 * Wa_1408615072:icl,ehl (vsunit)
1750 * Wa_1407596294:icl,ehl (hsunit)
1752 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE,
1753 VSUNIT_CLKGATE_DIS | HSUNIT_CLKGATE_DIS);
1755 /* Wa_1407352427:icl,ehl */
1756 wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
1757 PSDUNIT_CLKGATE_DIS);
1759 /* Wa_1406680159:icl,ehl */
1761 SUBSLICE_UNIT_LEVEL_CLKGATE,
1762 GWUNIT_CLKGATE_DIS);
1765 * Wa_1408767742:icl[a2..forever],ehl[all]
1766 * Wa_1605460711:icl[a0..c0]
1769 GEN7_FF_THREAD_MODE,
1770 GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
1772 /* Wa_22010271021 */
1774 GEN9_CS_DEBUG_MODE1,
1775 FF_DOP_CLOCK_GATE_DISABLE);
1778 if (IS_GRAPHICS_VER(i915, 9, 12)) {
1779 /* FtrPerCtxtPreemptionGranularityControl:skl,bxt,kbl,cfl,cnl,icl,tgl */
1781 GEN7_FF_SLICE_CS_CHICKEN1,
1782 GEN9_FFSC_PERCTX_PREEMPT_CTRL);
1785 if (IS_SKYLAKE(i915) ||
1786 IS_KABYLAKE(i915) ||
1787 IS_COFFEELAKE(i915) ||
1788 IS_COMETLAKE(i915)) {
1789 /* WaEnableGapsTsvCreditFix:skl,kbl,cfl */
1792 GEN9_GAPS_TSV_CREDIT_DISABLE);
1795 if (IS_BROXTON(i915)) {
1796 /* WaDisablePooledEuLoadBalancingFix:bxt */
1798 FF_SLICE_CS_CHICKEN2,
1799 GEN9_POOLED_EU_LOAD_BALANCING_FIX_DISABLE);
1802 if (GRAPHICS_VER(i915) == 9) {
1803 /* WaContextSwitchWithConcurrentTLBInvalidate:skl,bxt,kbl,glk,cfl */
1805 GEN9_CSFE_CHICKEN1_RCS,
1806 GEN9_PREEMPT_GPGPU_SYNC_SWITCH_DISABLE);
1808 /* WaEnableLbsSlaRetryTimerDecrement:skl,bxt,kbl,glk,cfl */
1811 GEN9_LBS_SLA_RETRY_TIMER_DECREMENT_ENABLE);
1813 /* WaProgramL3SqcReg1DefaultForPerf:bxt,glk */
1814 if (IS_GEN9_LP(i915))
1815 wa_write_clr_set(wal,
1817 L3_PRIO_CREDITS_MASK,
1818 L3_GENERAL_PRIO_CREDITS(62) |
1819 L3_HIGH_PRIO_CREDITS(2));
1821 /* WaOCLCoherentLineFlush:skl,bxt,kbl,cfl */
1824 GEN8_LQSC_FLUSH_COHERENT_LINES);
1826 /* Disable atomics in L3 to prevent unrecoverable hangs */
1827 wa_write_clr_set(wal, GEN9_SCRATCH_LNCF1,
1828 GEN9_LNCF_NONIA_COHERENT_ATOMICS_ENABLE, 0);
1829 wa_write_clr_set(wal, GEN8_L3SQCREG4,
1830 GEN8_LQSQ_NONIA_COHERENT_ATOMICS_ENABLE, 0);
1831 wa_write_clr_set(wal, GEN9_SCRATCH1,
1832 EVICTION_PERF_FIX_ENABLE, 0);
1835 if (IS_HASWELL(i915)) {
1836 /* WaSampleCChickenBitEnable:hsw */
1838 HALF_SLICE_CHICKEN3, HSW_SAMPLE_C_PERFORMANCE);
1842 /* enable HiZ Raw Stall Optimization */
1843 HIZ_RAW_STALL_OPT_DISABLE);
1846 if (IS_VALLEYVIEW(i915)) {
1847 /* WaDisableEarlyCull:vlv */
1850 _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);
1853 * WaVSThreadDispatchOverride:ivb,vlv
1855 * This actually overrides the dispatch
1856 * mode for all thread types.
1858 wa_write_clr_set(wal,
1859 GEN7_FF_THREAD_MODE,
1861 GEN7_FF_TS_SCHED_HW |
1862 GEN7_FF_VS_SCHED_HW |
1863 GEN7_FF_DS_SCHED_HW);
1865 /* WaPsdDispatchEnable:vlv */
1866 /* WaDisablePSDDualDispatchEnable:vlv */
1868 GEN7_HALF_SLICE_CHICKEN1,
1869 GEN7_MAX_PS_THREAD_DEP |
1870 GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
1873 if (IS_IVYBRIDGE(i915)) {
1874 /* WaDisableEarlyCull:ivb */
1877 _3D_CHICKEN_SF_DISABLE_OBJEND_CULL);
1879 if (0) { /* causes HiZ corruption on ivb:gt1 */
1880 /* enable HiZ Raw Stall Optimization */
1883 HIZ_RAW_STALL_OPT_DISABLE);
1887 * WaVSThreadDispatchOverride:ivb,vlv
1889 * This actually overrides the dispatch
1890 * mode for all thread types.
1892 wa_write_clr_set(wal,
1893 GEN7_FF_THREAD_MODE,
1895 GEN7_FF_TS_SCHED_HW |
1896 GEN7_FF_VS_SCHED_HW |
1897 GEN7_FF_DS_SCHED_HW);
1899 /* WaDisablePSDDualDispatchEnable:ivb */
1900 if (IS_IVB_GT1(i915))
1902 GEN7_HALF_SLICE_CHICKEN1,
1903 GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE);
1906 if (GRAPHICS_VER(i915) == 7) {
1907 /* WaBCSVCSTlbInvalidationMode:ivb,vlv,hsw */
1910 GFX_TLB_INVALIDATE_EXPLICIT | GFX_REPLAY_MODE);
1912 /* WaDisable_RenderCache_OperationalFlush:ivb,vlv,hsw */
1913 wa_masked_dis(wal, CACHE_MODE_0_GEN7, RC_OP_FLUSH_ENABLE);
1916 * BSpec says this must be set, even though
1917 * WaDisable4x2SubspanOptimization:ivb,hsw
1918 * WaDisable4x2SubspanOptimization isn't listed for VLV.
1922 PIXEL_SUBSPAN_COLLECT_OPT_DISABLE);
1925 * BSpec recommends 8x4 when MSAA is used,
1926 * however in practice 16x4 seems fastest.
1928 * Note that PS/WM thread counts depend on the WIZ hashing
1929 * disable bit, which we don't touch here, but it's good
1930 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
1932 wa_add(wal, GEN7_GT_MODE, 0,
1933 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK,
1934 GEN6_WIZ_HASHING_16x4),
1935 GEN6_WIZ_HASHING_16x4);
1938 if (IS_GRAPHICS_VER(i915, 6, 7))
1940 * We need to disable the AsyncFlip performance optimisations in
1941 * order to use MI_WAIT_FOR_EVENT within the CS. It should
1942 * already be programmed to '1' on all products.
1944 * WaDisableAsyncFlipPerfMode:snb,ivb,hsw,vlv
1948 ASYNC_FLIP_PERF_DISABLE);
1950 if (GRAPHICS_VER(i915) == 6) {
1952 * Required for the hardware to program scanline values for
1954 * WaEnableFlushTlbInvalidationMode:snb
1958 GFX_TLB_INVALIDATE_EXPLICIT);
1960 /* WaDisableHiZPlanesWhenMSAAEnabled:snb */
1963 _3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB);
1967 /* WaStripsFansDisableFastClipPerformanceFix:snb */
1968 _3D_CHICKEN3_SF_DISABLE_FASTCLIP_CULL |
1971 * "This bit must be set if 3DSTATE_CLIP clip mode is set
1972 * to normal and 3DSTATE_SF number of SF output attributes
1975 _3D_CHICKEN3_SF_DISABLE_PIPELINED_ATTR_FETCH);
1978 * BSpec recommends 8x4 when MSAA is used,
1979 * however in practice 16x4 seems fastest.
1981 * Note that PS/WM thread counts depend on the WIZ hashing
1982 * disable bit, which we don't touch here, but it's good
1983 * to keep in mind (see 3DSTATE_PS and 3DSTATE_WM).
1987 _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4),
1988 GEN6_WIZ_HASHING_16x4);
1990 /* WaDisable_RenderCache_OperationalFlush:snb */
1991 wa_masked_dis(wal, CACHE_MODE_0, RC_OP_FLUSH_ENABLE);
1994 * From the Sandybridge PRM, volume 1 part 3, page 24:
1995 * "If this bit is set, STCunit will have LRA as replacement
1996 * policy. [...] This bit must be reset. LRA replacement
1997 * policy is not supported."
2001 CM0_STC_EVICT_DISABLE_LRA_SNB);
2004 if (IS_GRAPHICS_VER(i915, 4, 6))
2005 /* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */
2006 wa_add(wal, MI_MODE,
2007 0, _MASKED_BIT_ENABLE(VS_TIMER_DISPATCH),
2008 /* XXX bit doesn't stick on Broadwater */
2009 IS_I965G(i915) ? 0 : VS_TIMER_DISPATCH);
2011 if (GRAPHICS_VER(i915) == 4)
2013 * Disable CONSTANT_BUFFER before it is loaded from the context
2014 * image. For as it is loaded, it is executed and the stored
2015 * address may no longer be valid, leading to a GPU hang.
2017 * This imposes the requirement that userspace reload their
2018 * CONSTANT_BUFFER on every batch, fortunately a requirement
2019 * they are already accustomed to from before contexts were
2022 wa_add(wal, ECOSKPD,
2023 0, _MASKED_BIT_ENABLE(ECO_CONSTANT_BUFFER_SR_DISABLE),
2024 0 /* XXX bit doesn't stick on Broadwater */);
2028 xcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
2030 struct drm_i915_private *i915 = engine->i915;
2032 /* WaKBLVECSSemaphoreWaitPoll:kbl */
2033 if (IS_KBL_GT_STEP(i915, STEP_A0, STEP_E0)) {
2035 RING_SEMA_WAIT_POLL(engine->mmio_base),
2041 engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal)
2043 if (I915_SELFTEST_ONLY(GRAPHICS_VER(engine->i915) < 4))
2046 if (engine->class == RENDER_CLASS)
2047 rcs_engine_wa_init(engine, wal);
2049 xcs_engine_wa_init(engine, wal);
2052 void intel_engine_init_workarounds(struct intel_engine_cs *engine)
2054 struct i915_wa_list *wal = &engine->wa_list;
2056 if (GRAPHICS_VER(engine->i915) < 4)
2059 wa_init_start(wal, "engine", engine->name);
2060 engine_init_workarounds(engine, wal);
2061 wa_init_finish(wal);
2064 void intel_engine_apply_workarounds(struct intel_engine_cs *engine)
2066 wa_list_apply(engine->gt, &engine->wa_list);
2074 static const struct mcr_range mcr_ranges_gen8[] = {
2075 { .start = 0x5500, .end = 0x55ff },
2076 { .start = 0x7000, .end = 0x7fff },
2077 { .start = 0x9400, .end = 0x97ff },
2078 { .start = 0xb000, .end = 0xb3ff },
2079 { .start = 0xe000, .end = 0xe7ff },
2083 static const struct mcr_range mcr_ranges_gen12[] = {
2084 { .start = 0x8150, .end = 0x815f },
2085 { .start = 0x9520, .end = 0x955f },
2086 { .start = 0xb100, .end = 0xb3ff },
2087 { .start = 0xde80, .end = 0xe8ff },
2088 { .start = 0x24a00, .end = 0x24a7f },
2092 static bool mcr_range(struct drm_i915_private *i915, u32 offset)
2094 const struct mcr_range *mcr_ranges;
2097 if (GRAPHICS_VER(i915) >= 12)
2098 mcr_ranges = mcr_ranges_gen12;
2099 else if (GRAPHICS_VER(i915) >= 8)
2100 mcr_ranges = mcr_ranges_gen8;
2105 * Registers in these ranges are affected by the MCR selector
2106 * which only controls CPU initiated MMIO. Routing does not
2107 * work for CS access so we cannot verify them on this path.
2109 for (i = 0; mcr_ranges[i].start; i++)
2110 if (offset >= mcr_ranges[i].start &&
2111 offset <= mcr_ranges[i].end)
2118 wa_list_srm(struct i915_request *rq,
2119 const struct i915_wa_list *wal,
2120 struct i915_vma *vma)
2122 struct drm_i915_private *i915 = rq->engine->i915;
2123 unsigned int i, count = 0;
2124 const struct i915_wa *wa;
2127 srm = MI_STORE_REGISTER_MEM | MI_SRM_LRM_GLOBAL_GTT;
2128 if (GRAPHICS_VER(i915) >= 8)
2131 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
2132 if (!mcr_range(i915, i915_mmio_reg_offset(wa->reg)))
2136 cs = intel_ring_begin(rq, 4 * count);
2140 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
2141 u32 offset = i915_mmio_reg_offset(wa->reg);
2143 if (mcr_range(i915, offset))
2148 *cs++ = i915_ggtt_offset(vma) + sizeof(u32) * i;
2151 intel_ring_advance(rq, cs);
2156 static int engine_wa_list_verify(struct intel_context *ce,
2157 const struct i915_wa_list * const wal,
2160 const struct i915_wa *wa;
2161 struct i915_request *rq;
2162 struct i915_vma *vma;
2163 struct i915_gem_ww_ctx ww;
2171 vma = __vm_create_scratch_for_read(&ce->engine->gt->ggtt->vm,
2172 wal->count * sizeof(u32));
2174 return PTR_ERR(vma);
2176 intel_engine_pm_get(ce->engine);
2177 i915_gem_ww_ctx_init(&ww, false);
2179 err = i915_gem_object_lock(vma->obj, &ww);
2181 err = intel_context_pin_ww(ce, &ww);
2185 err = i915_vma_pin_ww(vma, &ww, 0, 0,
2186 i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);
2190 rq = i915_request_create(ce);
2196 err = i915_request_await_object(rq, vma->obj, true);
2198 err = i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
2200 err = wa_list_srm(rq, wal, vma);
2202 i915_request_get(rq);
2204 i915_request_set_error_once(rq, err);
2205 i915_request_add(rq);
2210 if (i915_request_wait(rq, 0, HZ / 5) < 0) {
2215 results = i915_gem_object_pin_map(vma->obj, I915_MAP_WB);
2216 if (IS_ERR(results)) {
2217 err = PTR_ERR(results);
2222 for (i = 0, wa = wal->list; i < wal->count; i++, wa++) {
2223 if (mcr_range(rq->engine->i915, i915_mmio_reg_offset(wa->reg)))
2226 if (!wa_verify(wa, results[i], wal->name, from))
2230 i915_gem_object_unpin_map(vma->obj);
2233 i915_request_put(rq);
2235 i915_vma_unpin(vma);
2237 intel_context_unpin(ce);
2239 if (err == -EDEADLK) {
2240 err = i915_gem_ww_ctx_backoff(&ww);
2244 i915_gem_ww_ctx_fini(&ww);
2245 intel_engine_pm_put(ce->engine);
2250 int intel_engine_verify_workarounds(struct intel_engine_cs *engine,
2253 return engine_wa_list_verify(engine->kernel_context,
2258 #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
2259 #include "selftest_workarounds.c"