Makefile: Enable -Wimplicit-fallthrough for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 12 Jul 2021 05:57:54 +0000 (00:57 -0500)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 14 Jul 2021 16:12:21 +0000 (11:12 -0500)
commitb7eb335e26a9c7f258c96b3962c283c379d3ede0
tree1681cf86cd19106591630f4144806aaa643f7039
parent104aba8dd7dca85d82e94aba07e71994ccdaf4cf
Makefile: Enable -Wimplicit-fallthrough for Clang

With the recent fixes for fallthrough warnings, it is now possible to
enable -Wimplicit-fallthrough for Clang.

It's important to mention that since we have adopted the use of the
pseudo-keyword macro fallthrough; we also want to avoid having more
/* fall through */ comments being introduced. Notice that contrary
to GCC, Clang doesn't recognize any comments as implicit fall-through
markings when the -Wimplicit-fallthrough option is enabled. So, in
order to avoid having more comments being introduced, we have to use
the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang,
will cause a warning in case a code comment is intended to be used
as a fall-through marking.

Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Makefile