mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling
authorJason Gunthorpe <jgg@mellanox.com>
Thu, 5 Mar 2020 18:27:20 +0000 (14:27 -0400)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Mar 2020 17:33:37 +0000 (14:33 -0300)
commit4055062749229101365e5f9e87cb1c5a93e292f8
treeea0e9cfb1deaa87f6900242af536f46192ba2931
parent2288a9a68175cec9f91afb52948ba585b690774b
mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling

Currently if a special PTE is encountered hmm_range_fault() immediately
returns EFAULT and sets the HMM_PFN_SPECIAL error output (which nothing
uses).

EFAULT should only be returned after testing with hmm_pte_need_fault().

Also pte_devmap() and pte_special() are exclusive, and there is no need to
check IS_ENABLED, pte_special() is stubbed out to return false on
unsupported architectures.

Fixes: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX backed filesystem")
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
mm/hmm.c