selftests/core: add test for CLOSE_RANGE_UNSHARE | CLOSE_RANGE_CLOEXEC
authorChristian Brauner <christian.brauner@ubuntu.com>
Fri, 18 Dec 2020 14:54:14 +0000 (15:54 +0100)
committerChristian Brauner <christian.brauner@ubuntu.com>
Sat, 19 Dec 2020 15:23:18 +0000 (16:23 +0100)
Add a test to verify that CLOSE_RANGE_UNSHARE works correctly when combined
with CLOSE_RANGE_CLOEXEC for the single-threaded case.

Cc: Giuseppe Scrivano <gscrivan@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Link: https://lore.kernel.org/r/20201218145415.801063-3-christian.brauner@ubuntu.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
tools/testing/selftests/core/close_range_test.c

index bc592a1..862444f 100644 (file)
@@ -313,5 +313,75 @@ TEST(close_range_cloexec)
        }
 }
 
+TEST(close_range_cloexec_unshare)
+{
+       int i, ret;
+       int open_fds[101];
+       struct rlimit rlimit;
+
+       for (i = 0; i < ARRAY_SIZE(open_fds); i++) {
+               int fd;
+
+               fd = open("/dev/null", O_RDONLY);
+               ASSERT_GE(fd, 0) {
+                       if (errno == ENOENT)
+                               SKIP(return, "Skipping test since /dev/null does not exist");
+               }
+
+               open_fds[i] = fd;
+       }
+
+       ret = sys_close_range(1000, 1000, CLOSE_RANGE_CLOEXEC);
+       if (ret < 0) {
+               if (errno == ENOSYS)
+                       SKIP(return, "close_range() syscall not supported");
+               if (errno == EINVAL)
+                       SKIP(return, "close_range() doesn't support CLOSE_RANGE_CLOEXEC");
+       }
+
+       /* Ensure the FD_CLOEXEC bit is set also with a resource limit in place.  */
+       ASSERT_EQ(0, getrlimit(RLIMIT_NOFILE, &rlimit));
+       rlimit.rlim_cur = 25;
+       ASSERT_EQ(0, setrlimit(RLIMIT_NOFILE, &rlimit));
+
+       /* Set close-on-exec for two ranges: [0-50] and [75-100].  */
+       ret = sys_close_range(open_fds[0], open_fds[50],
+                             CLOSE_RANGE_CLOEXEC | CLOSE_RANGE_UNSHARE);
+       ASSERT_EQ(0, ret);
+       ret = sys_close_range(open_fds[75], open_fds[100],
+                             CLOSE_RANGE_CLOEXEC | CLOSE_RANGE_UNSHARE);
+       ASSERT_EQ(0, ret);
+
+       for (i = 0; i <= 50; i++) {
+               int flags = fcntl(open_fds[i], F_GETFD);
+
+               EXPECT_GT(flags, -1);
+               EXPECT_EQ(flags & FD_CLOEXEC, FD_CLOEXEC);
+       }
+
+       for (i = 51; i <= 74; i++) {
+               int flags = fcntl(open_fds[i], F_GETFD);
+
+               EXPECT_GT(flags, -1);
+               EXPECT_EQ(flags & FD_CLOEXEC, 0);
+       }
+
+       for (i = 75; i <= 100; i++) {
+               int flags = fcntl(open_fds[i], F_GETFD);
+
+               EXPECT_GT(flags, -1);
+               EXPECT_EQ(flags & FD_CLOEXEC, FD_CLOEXEC);
+       }
+
+       /* Test a common pattern.  */
+       ret = sys_close_range(3, UINT_MAX,
+                             CLOSE_RANGE_CLOEXEC | CLOSE_RANGE_UNSHARE);
+       for (i = 0; i <= 100; i++) {
+               int flags = fcntl(open_fds[i], F_GETFD);
+
+               EXPECT_GT(flags, -1);
+               EXPECT_EQ(flags & FD_CLOEXEC, FD_CLOEXEC);
+       }
+}
 
 TEST_HARNESS_MAIN