net: qede: fix BE vs CPU comparison
authorAlexander Lobakin <alobakin@marvell.com>
Mon, 6 Jul 2020 15:38:21 +0000 (18:38 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Jul 2020 20:18:56 +0000 (13:18 -0700)
Flow Dissector's keys are mostly Network / Big Endian. U{16,32}_MAX are
the same in either of byteorders, but let's make sparse happy with
wrapping them into noops.

Signed-off-by: Alexander Lobakin <alobakin@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_filter.c

index db17a67..d810043 100644 (file)
@@ -1764,8 +1764,8 @@ qede_flow_parse_ports(struct qede_dev *edev, struct flow_rule *rule,
                struct flow_match_ports match;
 
                flow_rule_match_ports(rule, &match);
-               if ((match.key->src && match.mask->src != U16_MAX) ||
-                   (match.key->dst && match.mask->dst != U16_MAX)) {
+               if ((match.key->src && match.mask->src != htons(U16_MAX)) ||
+                   (match.key->dst && match.mask->dst != htons(U16_MAX))) {
                        DP_NOTICE(edev, "Do not support ports masks\n");
                        return -EINVAL;
                }
@@ -1817,8 +1817,8 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
                struct flow_match_ipv4_addrs match;
 
                flow_rule_match_ipv4_addrs(rule, &match);
-               if ((match.key->src && match.mask->src != U32_MAX) ||
-                   (match.key->dst && match.mask->dst != U32_MAX)) {
+               if ((match.key->src && match.mask->src != htonl(U32_MAX)) ||
+                   (match.key->dst && match.mask->dst != htonl(U32_MAX))) {
                        DP_NOTICE(edev, "Do not support ipv4 prefix/masks\n");
                        return -EINVAL;
                }