xen-pciback: First reset, then free.
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 4 Dec 2013 02:37:24 +0000 (21:37 -0500)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Fri, 23 May 2014 16:33:36 +0000 (12:33 -0400)
We were doing the operations of freeing and reset in the wrong
order. Granted nothing broke because the reset functions just
set bar->which = 0.

But nonethless this was incorrect.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
drivers/xen/xen-pciback/pci_stub.c

index 5300a21..36dd4f3 100644 (file)
@@ -278,8 +278,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
        xen_pcibk_reset_device(dev);
 
        /* And cleanup up our emulated fields. */
-       xen_pcibk_config_free_dyn_fields(dev);
        xen_pcibk_config_reset_dev(dev);
+       xen_pcibk_config_free_dyn_fields(dev);
 
        xen_unregister_device_domain_owner(dev);