ACPI: power: Use acpi_handle_debug() to print debug messages
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 27 Aug 2021 19:07:58 +0000 (21:07 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 27 Aug 2021 19:07:58 +0000 (21:07 +0200)
Use acpi_handle_debug() to print diagnostic messages regarding ACPI
power resources so as to make it easier to correlate the kernel
messages with the power resource objects in the ACPI namespace that
they are about.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/power.c

index eba7785..21d4280 100644 (file)
@@ -356,10 +356,11 @@ void acpi_device_power_remove_dependent(struct acpi_device *adev,
 
 static int __acpi_power_on(struct acpi_power_resource *resource)
 {
+       acpi_handle handle = resource->device.handle;
        struct acpi_power_dependent_device *dep;
        acpi_status status = AE_OK;
 
-       status = acpi_evaluate_object(resource->device.handle, "_ON", NULL, NULL);
+       status = acpi_evaluate_object(handle, "_ON", NULL, NULL);
        if (ACPI_FAILURE(status)) {
                resource->state = ACPI_POWER_RESOURCE_STATE_UNKNOWN;
                return -ENODEV;
@@ -367,7 +368,7 @@ static int __acpi_power_on(struct acpi_power_resource *resource)
 
        resource->state = ACPI_POWER_RESOURCE_STATE_ON;
 
-       pr_debug("Power resource [%s] turned on\n", resource->name);
+       acpi_handle_debug(handle, "Power resource turned on\n");
 
        /*
         * If there are other dependents on this power resource we need to
@@ -392,7 +393,8 @@ static int acpi_power_on_unlocked(struct acpi_power_resource *resource)
        int result = 0;
 
        if (resource->ref_count++) {
-               pr_debug("Power resource [%s] already on\n", resource->name);
+               acpi_handle_debug(resource->device.handle,
+                                 "Power resource already on\n");
        } else {
                result = __acpi_power_on(resource);
                if (result)
@@ -413,10 +415,10 @@ static int acpi_power_on(struct acpi_power_resource *resource)
 
 static int __acpi_power_off(struct acpi_power_resource *resource)
 {
+       acpi_handle handle = resource->device.handle;
        acpi_status status;
 
-       status = acpi_evaluate_object(resource->device.handle, "_OFF",
-                                     NULL, NULL);
+       status = acpi_evaluate_object(handle, "_OFF", NULL, NULL);
        if (ACPI_FAILURE(status)) {
                resource->state = ACPI_POWER_RESOURCE_STATE_UNKNOWN;
                return -ENODEV;
@@ -424,7 +426,7 @@ static int __acpi_power_off(struct acpi_power_resource *resource)
 
        resource->state = ACPI_POWER_RESOURCE_STATE_OFF;
 
-       pr_debug("Power resource [%s] turned off\n", resource->name);
+       acpi_handle_debug(handle, "Power resource turned off\n");
 
        return 0;
 }
@@ -434,12 +436,14 @@ static int acpi_power_off_unlocked(struct acpi_power_resource *resource)
        int result = 0;
 
        if (!resource->ref_count) {
-               pr_debug("Power resource [%s] already off\n", resource->name);
+               acpi_handle_debug(resource->device.handle,
+                                 "Power resource already off\n");
                return 0;
        }
 
        if (--resource->ref_count) {
-               pr_debug("Power resource [%s] still in use\n", resource->name);
+               acpi_handle_debug(resource->device.handle,
+                                 "Power resource still in use\n");
        } else {
                result = __acpi_power_off(resource);
                if (result)
@@ -1004,7 +1008,7 @@ void acpi_resume_power_resources(void)
 
                if (state == ACPI_POWER_RESOURCE_STATE_OFF
                    && resource->ref_count) {
-                       dev_dbg(&resource->device.dev, "Turning ON\n");
+                       acpi_handle_debug(resource->device.handle, "Turning ON\n");
                        __acpi_power_on(resource);
                }
 
@@ -1034,7 +1038,7 @@ void acpi_turn_off_unused_power_resources(void)
                 */
                if (!resource->ref_count &&
                    resource->state != ACPI_POWER_RESOURCE_STATE_OFF) {
-                       dev_dbg(&resource->device.dev, "Turning OFF\n");
+                       acpi_handle_debug(resource->device.handle, "Turning OFF\n");
                        __acpi_power_off(resource);
                }