kconfig: qconf: create QApplication after option checks
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 29 Aug 2020 08:14:17 +0000 (17:14 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Thu, 24 Sep 2020 15:37:13 +0000 (00:37 +0900)
'scripts/kconfig/qconf -h' just calls usage() and exits, with
QApplication unused.

There is no need to construct QApplication so early. Do it after
the parse stage.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
scripts/kconfig/qconf.cc

index 21871b7..f7eb093 100644 (file)
@@ -1851,7 +1851,6 @@ int main(int ac, char** av)
        const char *name;
 
        progname = av[0];
-       configApp = new QApplication(ac, av);
        if (ac > 1 && av[1][0] == '-') {
                switch (av[1][1]) {
                case 's':
@@ -1872,6 +1871,8 @@ int main(int ac, char** av)
        conf_read(NULL);
        //zconfdump(stdout);
 
+       configApp = new QApplication(ac, av);
+
        configSettings = new ConfigSettings();
        configSettings->beginGroup("/kconfig/qconf");
        v = new ConfigMainWindow();