perf probe: Support probes on init functions for offline kernel
authorMasami Hiramatsu <mhiramat@kernel.org>
Fri, 4 Jun 2021 16:28:23 +0000 (01:28 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 18 Jun 2021 16:50:05 +0000 (13:50 -0300)
'perf probe' internally checks the probe target is in the text area in
post-process (after analyzing debuginfo). But it fails if the probe
target is in the "inittext".

This is a good limitation for the online kernel because such functions
have gone after booting. However, for using it for boot-time tracing,
user may want to put a probe on init functions.

This skips the post checking process if the target is offline kenrel so
that user can get the probe definition on the init functions.

Without this patch:

  $ perf probe -k ./build-x86_64/vmlinux -D do_mount_root:10
  Probe point 'do_mount_root:10' not found.
    Error: Failed to add events.

With this patch:

  $ perf probe -k ./build-x86_64/vmlinux -D do_mount_root:10
  p:probe/do_mount_root_L10 mount_block_root+300

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/162282410293.452340.13347006295826431632.stgit@devnote2
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-event.c

index 0568461..0fb6ab2 100644 (file)
@@ -682,8 +682,13 @@ static int post_process_probe_trace_point(struct probe_trace_point *tp,
        u64 addr = tp->address - offs;
 
        sym = map__find_symbol(map, addr);
-       if (!sym)
-               return -ENOENT;
+       if (!sym) {
+               /*
+                * If the address is in the inittext section, map can not
+                * find it. Ignore it if we are probing offline kernel.
+                */
+               return (symbol_conf.ignore_vmlinux_buildid) ? 0 : -ENOENT;
+       }
 
        if (strcmp(sym->name, tp->symbol)) {
                /* If we have no realname, use symbol for it */