powerpc/85xx: Fix declaration made after definition
authorMichael Ellerman <mpe@ellerman.id.au>
Fri, 23 Oct 2020 02:08:38 +0000 (13:08 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 19 Nov 2020 03:50:13 +0000 (14:50 +1100)
Currently the clang build of corenet64_smp_defconfig fails with:

  arch/powerpc/platforms/85xx/corenet_generic.c:210:1: error:
  attribute declaration must precede definition
  machine_arch_initcall(corenet_generic, corenet_gen_publish_devices);

Fix it by moving the initcall definition prior to the machine
definition, and directly below the function it calls, which is the
usual style anyway.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201023020838.3274226-1-mpe@ellerman.id.au
arch/powerpc/platforms/85xx/corenet_generic.c

index 6aa8def..8d60290 100644 (file)
@@ -106,6 +106,7 @@ int __init corenet_gen_publish_devices(void)
 {
        return of_platform_bus_probe(NULL, of_device_ids, NULL);
 }
+machine_arch_initcall(corenet_generic, corenet_gen_publish_devices);
 
 static const char * const boards[] __initconst = {
        "fsl,P2041RDB",
@@ -206,5 +207,3 @@ define_machine(corenet_generic) {
        .power_save             = e500_idle,
 #endif
 };
-
-machine_arch_initcall(corenet_generic, corenet_gen_publish_devices);