video: sa1100fb: Remove cpufreq policy notifier
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 23 Jul 2019 06:14:07 +0000 (11:44 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 26 Aug 2019 08:02:02 +0000 (10:02 +0200)
The cpufreq policy notifier's CPUFREQ_ADJUST notification is going to
get removed soon.

The notifier callback sa1100fb_freq_policy() isn't doing anything apart
from printing a debug message on CPUFREQ_ADJUST notification. There is
no point in keeping an otherwise empty callback and registering the
notifier.

Remove it.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/video/fbdev/sa1100fb.c
drivers/video/fbdev/sa1100fb.h

index f7f8dee..ae2bcfe 100644 (file)
@@ -1005,31 +1005,6 @@ sa1100fb_freq_transition(struct notifier_block *nb, unsigned long val,
        }
        return 0;
 }
-
-static int
-sa1100fb_freq_policy(struct notifier_block *nb, unsigned long val,
-                    void *data)
-{
-       struct sa1100fb_info *fbi = TO_INF(nb, freq_policy);
-       struct cpufreq_policy *policy = data;
-
-       switch (val) {
-       case CPUFREQ_ADJUST:
-               dev_dbg(fbi->dev, "min dma period: %d ps, "
-                       "new clock %d kHz\n", sa1100fb_min_dma_period(fbi),
-                       policy->max);
-               /* todo: fill in min/max values */
-               break;
-       case CPUFREQ_NOTIFY:
-               do {} while(0);
-               /* todo: panic if min/max values aren't fulfilled 
-                * [can't really happen unless there's a bug in the
-                * CPU policy verififcation process *
-                */
-               break;
-       }
-       return 0;
-}
 #endif
 
 #ifdef CONFIG_PM
@@ -1242,9 +1217,7 @@ static int sa1100fb_probe(struct platform_device *pdev)
 
 #ifdef CONFIG_CPU_FREQ
        fbi->freq_transition.notifier_call = sa1100fb_freq_transition;
-       fbi->freq_policy.notifier_call = sa1100fb_freq_policy;
        cpufreq_register_notifier(&fbi->freq_transition, CPUFREQ_TRANSITION_NOTIFIER);
-       cpufreq_register_notifier(&fbi->freq_policy, CPUFREQ_POLICY_NOTIFIER);
 #endif
 
        /* This driver cannot be unloaded at the moment */
index 7a1a9ca..d0aa33b 100644 (file)
@@ -64,7 +64,6 @@ struct sa1100fb_info {
 
 #ifdef CONFIG_CPU_FREQ
        struct notifier_block   freq_transition;
-       struct notifier_block   freq_policy;
 #endif
 
        const struct sa1100fb_mach_info *inf;