scripts: coccinelle: allow list_entry_is_head() to use pos
authorDaniel Thompson <daniel.thompson@linaro.org>
Fri, 30 Jul 2021 09:58:56 +0000 (10:58 +0100)
committerJulia Lawall <Julia.Lawall@inria.fr>
Sun, 8 Aug 2021 20:00:49 +0000 (22:00 +0200)
Currently use_after_iter.cocci generates false positives for code of the
following form:
~~~
list_for_each_entry(d, &ddata->irq_list, node) {
if (irq == d->irq)
break;
}

if (list_entry_is_head(d, &ddata->irq_list, node))
return IRQ_NONE;
~~~
[This specific example comes from drivers/power/supply/cpcap-battery.c]

Most list macros use list_entry_is_head() as loop exit condition meaning it
is not unsafe to reuse pos (a.k.a. d) in the code above.

Let's avoid reporting these cases.

Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
scripts/coccinelle/iterators/use_after_iter.cocci

index 9be48b5..676edd5 100644 (file)
@@ -123,6 +123,8 @@ hlist_for_each_entry_safe(c,...) S
 |
 list_remove_head(x,c,...)
 |
+list_entry_is_head(c,...)
+|
 sizeof(<+...c...+>)
 |
  &c->member