scsi: megaraid_sas: remove set but not used variable 'cur_state'
authorYueHaibing <yuehaibing@huawei.com>
Sat, 25 May 2019 12:38:21 +0000 (20:38 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 18 Jun 2019 23:46:23 +0000 (19:46 -0400)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_transition_to_ready:
drivers/scsi/megaraid/megaraid_sas_base.c:3900:6: warning: variable cur_state set but not used [-Wunused-but-set-variable]

Never used since commit 7218df69e360 ("[SCSI] megaraid_sas: use the
firmware boot timeout when waiting for commands")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c

index 3a9128e..5397b12 100644 (file)
@@ -3909,7 +3909,6 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
        int i;
        u8 max_wait;
        u32 fw_state;
-       u32 cur_state;
        u32 abs_state, curr_abs_state;
 
        abs_state = instance->instancet->read_fw_status_reg(instance);
@@ -3930,7 +3929,6 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                                   abs_state & MFI_STATE_FAULT_SUBCODE, __func__);
                        if (ocr) {
                                max_wait = MEGASAS_RESET_WAIT_TIME;
-                               cur_state = MFI_STATE_FAULT;
                                break;
                        } else {
                                dev_printk(KERN_DEBUG, &instance->pdev->dev, "System Register set:\n");
@@ -3956,7 +3954,6 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                                        &instance->reg_set->inbound_doorbell);
 
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_WAIT_HANDSHAKE;
                        break;
 
                case MFI_STATE_BOOT_MESSAGE_PENDING:
@@ -3972,7 +3969,6 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                                        &instance->reg_set->inbound_doorbell);
 
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_BOOT_MESSAGE_PENDING;
                        break;
 
                case MFI_STATE_OPERATIONAL:
@@ -4005,7 +4001,6 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                                        &instance->reg_set->inbound_doorbell);
 
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_OPERATIONAL;
                        break;
 
                case MFI_STATE_UNDEFINED:
@@ -4013,32 +4008,26 @@ megasas_transition_to_ready(struct megasas_instance *instance, int ocr)
                         * This state should not last for more than 2 seconds
                         */
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_UNDEFINED;
                        break;
 
                case MFI_STATE_BB_INIT:
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_BB_INIT;
                        break;
 
                case MFI_STATE_FW_INIT:
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_FW_INIT;
                        break;
 
                case MFI_STATE_FW_INIT_2:
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_FW_INIT_2;
                        break;
 
                case MFI_STATE_DEVICE_SCAN:
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_DEVICE_SCAN;
                        break;
 
                case MFI_STATE_FLUSH_CACHE:
                        max_wait = MEGASAS_RESET_WAIT_TIME;
-                       cur_state = MFI_STATE_FLUSH_CACHE;
                        break;
 
                default: