octeontx2-af: Fix undetected unmap PF error check
authorColin Ian King <colin.king@canonical.com>
Wed, 16 Dec 2020 12:36:04 +0000 (12:36 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Dec 2020 18:57:43 +0000 (10:57 -0800)
Currently the check for an unmap PF error is always going to be false
because intr_val is a 32 bit int and is being bit-mask checked against
1ULL << 32.  Fix this by making intr_val a u64 to match the type at it
is copied from, namely npa_event_context->npa_af_rvu_ge.

Addresses-Coverity: ("Operands don't affect result")
Fixes: f1168d1e207c ("octeontx2-af: Add devlink health reporters for NPA")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: George Cherian <george.cherian@marvell.com>
Link: https://lore.kernel.org/r/20201216123604.15369-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c

index 3f9d0ab..bc0e411 100644 (file)
@@ -275,7 +275,8 @@ static int rvu_npa_report_show(struct devlink_fmsg *fmsg, void *ctx,
                               enum npa_af_rvu_health health_reporter)
 {
        struct rvu_npa_event_ctx *npa_event_context;
-       unsigned int intr_val, alloc_dis, free_dis;
+       unsigned int alloc_dis, free_dis;
+       u64 intr_val;
        int err;
 
        npa_event_context = ctx;