KVM: use kvcalloc for array allocations
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 8 Mar 2022 09:57:39 +0000 (04:57 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 21 Mar 2022 13:28:41 +0000 (09:28 -0400)
Instead of using array_size, use a function that takes care of the
multiplication.  While at it, switch to kvcalloc since this allocation
should not be very large.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/cpuid.c

index 32007f9..58b0b4e 100644 (file)
@@ -1290,8 +1290,7 @@ int kvm_dev_ioctl_get_cpuid(struct kvm_cpuid2 *cpuid,
        if (sanity_check_entries(entries, cpuid->nent, type))
                return -EINVAL;
 
-       array.entries = vzalloc(array_size(sizeof(struct kvm_cpuid_entry2),
-                                          cpuid->nent));
+       array.entries = kvcalloc(sizeof(struct kvm_cpuid_entry2), cpuid->nent, GFP_KERNEL);
        if (!array.entries)
                return -ENOMEM;
 
@@ -1309,7 +1308,7 @@ int kvm_dev_ioctl_get_cpuid(struct kvm_cpuid2 *cpuid,
                r = -EFAULT;
 
 out_free:
-       vfree(array.entries);
+       kvfree(array.entries);
        return r;
 }