xen/blocks: Return -EXX instead of -1
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 25 Nov 2015 18:07:39 +0000 (13:07 -0500)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Mon, 4 Jan 2016 17:21:07 +0000 (12:21 -0500)
Lets return sensible values instead of -1.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/block/xen-blkback/xenbus.c
drivers/block/xen-blkfront.c

index 2b8650a..ca3a414 100644 (file)
@@ -996,7 +996,7 @@ static int connect_ring(struct backend_info *be)
                be->blkif->blk_protocol = BLKIF_PROTOCOL_X86_64;
        else {
                xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
-               return -1;
+               return -ENOSYS;
        }
        err = xenbus_gather(XBT_NIL, dev->otherend,
                            "feature-persistent", "%u",
index 8b0f3d9..ef5ce43 100644 (file)
@@ -828,11 +828,11 @@ static int xlvbd_init_blk_queue(struct gendisk *gd, u16 sector_size,
        info->tag_set.driver_data = info;
 
        if (blk_mq_alloc_tag_set(&info->tag_set))
-               return -1;
+               return -EINVAL;
        rq = blk_mq_init_queue(&info->tag_set);
        if (IS_ERR(rq)) {
                blk_mq_free_tag_set(&info->tag_set);
-               return -1;
+               return PTR_ERR(rq);
        }
 
        queue_flag_set_unlocked(QUEUE_FLAG_VIRT, rq);