drm/amd/display: fix the return of the uninitialized value in ret
authorColin Ian King <colin.king@canonical.com>
Tue, 2 Mar 2021 14:05:09 +0000 (14:05 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 4 Mar 2021 04:05:16 +0000 (23:05 -0500)
Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or
SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is
checked for > 0 at the end of the function.  Ret should be initialized,
I believe setting it to zero is a correct default.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use")
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

index 5159399..5750818 100644 (file)
@@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable(
 {
        uint8_t enable_dsc = enable ? 1 : 0;
        struct amdgpu_dm_connector *aconnector;
-       uint8_t ret;
+       uint8_t ret = 0;
 
        if (!stream)
                return false;