xen/privcmd: Mark pages as dirty
authorSouptick Joarder <jrdr.linux@gmail.com>
Sun, 12 Jul 2020 03:39:54 +0000 (09:09 +0530)
committerJuergen Gross <jgross@suse.com>
Mon, 3 Aug 2020 05:42:18 +0000 (07:42 +0200)
pages need to be marked as dirty before unpinned it in
unlock_pages() which was oversight. This is fixed now.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Suggested-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Paul Durrant <xadimgnik@gmail.com>
Link: https://lore.kernel.org/r/1594525195-28345-3-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/privcmd.c

index a9b2baa..aa8ca58 100644 (file)
@@ -612,8 +612,11 @@ static void unlock_pages(struct page *pages[], unsigned int nr_pages)
 {
        unsigned int i;
 
-       for (i = 0; i < nr_pages; i++)
+       for (i = 0; i < nr_pages; i++) {
+               if (!PageDirty(pages[i]))
+                       set_page_dirty_lock(pages[i]);
                put_page(pages[i]);
+       }
 }
 
 static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)