scsi: pm8001: Fix misindentation
authorJoe Perches <joe@perches.com>
Tue, 24 Nov 2020 04:36:04 +0000 (20:36 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Dec 2020 04:32:49 +0000 (23:32 -0500)
kernel robot reported a misindentation of a goto.

Fix it.

At the same time, use a temporary for a repeated entry in the same block to
reduce visual noise.

Link: https://lore.kernel.org/r/9542a8be9954c1dca744f93f53bb1af6dd1436e8.1606192458.git.joe@perches.com
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c

index aaac127..9a5d284 100644 (file)
@@ -386,17 +386,17 @@ static int pm8001_alloc(struct pm8001_hba_info *pm8001_ha,
        pm8001_ha->memoryMap.region[FORENSIC_MEM].element_size = 0x10000;
        pm8001_ha->memoryMap.region[FORENSIC_MEM].alignment = 0x10000;
        for (i = 0; i < pm8001_ha->max_memcnt; i++) {
+               struct mpi_mem *region = &pm8001_ha->memoryMap.region[i];
+
                if (pm8001_mem_alloc(pm8001_ha->pdev,
-                       &pm8001_ha->memoryMap.region[i].virt_ptr,
-                       &pm8001_ha->memoryMap.region[i].phys_addr,
-                       &pm8001_ha->memoryMap.region[i].phys_addr_hi,
-                       &pm8001_ha->memoryMap.region[i].phys_addr_lo,
-                       pm8001_ha->memoryMap.region[i].total_len,
-                       pm8001_ha->memoryMap.region[i].alignment) != 0) {
-                       pm8001_dbg(pm8001_ha, FAIL,
-                                  "Mem%d alloc failed\n",
-                                  i);
-                               goto err_out;
+                                    &region->virt_ptr,
+                                    &region->phys_addr,
+                                    &region->phys_addr_hi,
+                                    &region->phys_addr_lo,
+                                    region->total_len,
+                                    region->alignment) != 0) {
+                       pm8001_dbg(pm8001_ha, FAIL, "Mem%d alloc failed\n", i);
+                       goto err_out;
                }
        }