ARC: mm: do_page_fault refactor #6: error handlers to use same pattern
authorVineet Gupta <vgupta@synopsys.com>
Tue, 14 May 2019 22:10:45 +0000 (15:10 -0700)
committerVineet Gupta <vgupta@synopsys.com>
Mon, 1 Jul 2019 18:02:22 +0000 (11:02 -0700)
 - up_read
 - if !user_mode
 - whatever error handling

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
arch/arc/mm/fault.c

index b107e45..2672ce2 100644 (file)
@@ -191,22 +191,21 @@ retry:
 bad_area:
        up_read(&mm->mmap_sem);
 
-       /* User mode accesses just cause a SIGSEGV */
-       if (user_mode(regs)) {
-               tsk->thread.fault_address = address;
-               force_sig_fault(SIGSEGV, si_code, (void __user *)address, tsk);
-               return;
-       }
+       if (!user_mode(regs))
+               goto no_context;
+
+       tsk->thread.fault_address = address;
+       force_sig_fault(SIGSEGV, si_code, (void __user *)address, tsk);
+       return;
 
 out_of_memory:
        up_read(&mm->mmap_sem);
 
-       if (user_mode(regs)) {
-               pagefault_out_of_memory();
-               return;
-       }
+       if (!user_mode(regs))
+               goto no_context;
 
-       goto no_context;
+       pagefault_out_of_memory();
+       return;
 
 do_sigbus:
        up_read(&mm->mmap_sem);