rbd: remove barriers from img_request_layered_{set,clear,test}()
authorIlya Dryomov <idryomov@gmail.com>
Thu, 30 Jan 2020 12:54:59 +0000 (13:54 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 30 Mar 2020 10:42:40 +0000 (12:42 +0200)
IMG_REQ_LAYERED is set in rbd_img_request_create(), and tested and
cleared in rbd_img_request_destroy() when the image request is about to
be destroyed.  The barriers are unnecessary.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
drivers/block/rbd.c

index 6343402..162fd1d 100644 (file)
@@ -1366,18 +1366,15 @@ static void rbd_osd_submit(struct ceph_osd_request *osd_req)
 static void img_request_layered_set(struct rbd_img_request *img_request)
 {
        set_bit(IMG_REQ_LAYERED, &img_request->flags);
-       smp_mb();
 }
 
 static void img_request_layered_clear(struct rbd_img_request *img_request)
 {
        clear_bit(IMG_REQ_LAYERED, &img_request->flags);
-       smp_mb();
 }
 
 static bool img_request_layered_test(struct rbd_img_request *img_request)
 {
-       smp_mb();
        return test_bit(IMG_REQ_LAYERED, &img_request->flags) != 0;
 }