ACPI: video: Add quirk for the Dell Vostro 3350
authorHans de Goede <hdegoede@redhat.com>
Wed, 30 Jun 2021 15:23:16 +0000 (17:23 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 30 Jun 2021 18:03:41 +0000 (20:03 +0200)
The Dell Vostro 3350 ACPI video-bus device reports spurious
ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE
events being reported to userspace (and causing trouble there).

Add a quirk setting the report_key_events mask to
REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE
events will be ignored, while still reporting brightness up/down
hotkey-presses to userspace normally.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_video.c

index ffb4afc..42ede05 100644 (file)
@@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = {
                DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"),
                },
        },
+       {
+        .callback = video_set_report_key_events,
+        .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS),
+        .ident = "Dell Vostro 3350",
+        .matches = {
+               DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+               DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"),
+               },
+       },
        /*
         * Some machines change the brightness themselves when a brightness
         * hotkey gets pressed, despite us telling them not to. In this case