dm writecache: remove BUG() and fail gracefully instead
authorMike Snitzer <snitzer@redhat.com>
Fri, 13 Nov 2020 22:52:28 +0000 (14:52 -0800)
committerMike Snitzer <snitzer@redhat.com>
Tue, 1 Dec 2020 20:43:39 +0000 (15:43 -0500)
Building on arch/s390/ results in this build error:

cc1: some warnings being treated as errors
../drivers/md/dm-writecache.c: In function 'persistent_memory_claim':
../drivers/md/dm-writecache.c:323:1: error: no return statement in function returning non-void [-Werror=return-type]

Fix this by replacing the BUG() with an -EOPNOTSUPP return.

Fixes: 48debafe4f2f ("dm: add writecache target")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-writecache.c

index 7d277de..d5223a0 100644 (file)
@@ -319,7 +319,7 @@ err1:
 #else
 static int persistent_memory_claim(struct dm_writecache *wc)
 {
-       BUG();
+       return -EOPNOTSUPP;
 }
 #endif