drm/msm/dp: return correct edid checksum after corrupted edid checksum read
authorKuogee Hsieh <khsieh@codeaurora.org>
Thu, 5 Aug 2021 20:44:54 +0000 (13:44 -0700)
committerRob Clark <robdclark@chromium.org>
Tue, 10 Aug 2021 21:49:29 +0000 (14:49 -0700)
Response with correct edid checksum saved at connector after corrupted edid
checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6.

Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/1628196295-7382-6-git-send-email-khsieh@codeaurora.org
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dp/dp_panel.c

index 440b327..2181b60 100644 (file)
@@ -271,7 +271,7 @@ static u8 dp_panel_get_edid_checksum(struct edid *edid)
 {
        struct edid *last_block;
        u8 *raw_edid;
-       bool is_edid_corrupt;
+       bool is_edid_corrupt = false;
 
        if (!edid) {
                DRM_ERROR("invalid edid input\n");
@@ -303,7 +303,12 @@ void dp_panel_handle_sink_request(struct dp_panel *dp_panel)
        panel = container_of(dp_panel, struct dp_panel_private, dp_panel);
 
        if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) {
-               u8 checksum = dp_panel_get_edid_checksum(dp_panel->edid);
+               u8 checksum;
+
+               if (dp_panel->edid)
+                       checksum = dp_panel_get_edid_checksum(dp_panel->edid);
+               else
+                       checksum = dp_panel->connector->real_edid_checksum;
 
                dp_link_send_edid_checksum(panel->link, checksum);
                dp_link_send_test_response(panel->link);