fbmem: fix horribly incorrect placement of __maybe_unused
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 9 May 2021 21:03:33 +0000 (14:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 9 May 2021 21:03:33 +0000 (14:03 -0700)
Commit b9d79e4ca4ff ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
places the '__maybe_unused' in an entirely incorrect location between
the "struct" keyword and the structure name.

It's a wonder that gcc accepts that silently, but clang quite reasonably
warns about it:

    drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes]
    static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
                        ^

Fix it.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/fbdev/core/fbmem.c

index 52c606c..072780b 100644 (file)
@@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
        return 0;
 }
 
-static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
+static const struct seq_operations __maybe_unused proc_fb_seq_ops = {
        .start  = fb_seq_start,
        .next   = fb_seq_next,
        .stop   = fb_seq_stop,