drm/etnaviv: Simplify clock enable/disable
authorLubomir Rintel <lkundrak@v3.sk>
Tue, 16 Jun 2020 21:21:27 +0000 (23:21 +0200)
committerLucas Stach <l.stach@pengutronix.de>
Thu, 18 Jun 2020 12:23:11 +0000 (14:23 +0200)
All the NULL checks are pointless, clk_*() routines already deal with NULL
just fine.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/etnaviv/etnaviv_gpu.c

index 798fdbc..fb37787 100644 (file)
@@ -1487,55 +1487,40 @@ static int etnaviv_gpu_clk_enable(struct etnaviv_gpu *gpu)
 {
        int ret;
 
-       if (gpu->clk_reg) {
-               ret = clk_prepare_enable(gpu->clk_reg);
-               if (ret)
-                       return ret;
-       }
+       ret = clk_prepare_enable(gpu->clk_reg);
+       if (ret)
+               return ret;
 
-       if (gpu->clk_bus) {
-               ret = clk_prepare_enable(gpu->clk_bus);
-               if (ret)
-                       goto disable_clk_reg;
-       }
+       ret = clk_prepare_enable(gpu->clk_bus);
+       if (ret)
+               goto disable_clk_reg;
 
-       if (gpu->clk_core) {
-               ret = clk_prepare_enable(gpu->clk_core);
-               if (ret)
-                       goto disable_clk_bus;
-       }
+       ret = clk_prepare_enable(gpu->clk_core);
+       if (ret)
+               goto disable_clk_bus;
 
-       if (gpu->clk_shader) {
-               ret = clk_prepare_enable(gpu->clk_shader);
-               if (ret)
-                       goto disable_clk_core;
-       }
+       ret = clk_prepare_enable(gpu->clk_shader);
+       if (ret)
+               goto disable_clk_core;
 
        return 0;
 
 disable_clk_core:
-       if (gpu->clk_core)
-               clk_disable_unprepare(gpu->clk_core);
+       clk_disable_unprepare(gpu->clk_core);
 disable_clk_bus:
-       if (gpu->clk_bus)
-               clk_disable_unprepare(gpu->clk_bus);
+       clk_disable_unprepare(gpu->clk_bus);
 disable_clk_reg:
-       if (gpu->clk_reg)
-               clk_disable_unprepare(gpu->clk_reg);
+       clk_disable_unprepare(gpu->clk_reg);
 
        return ret;
 }
 
 static int etnaviv_gpu_clk_disable(struct etnaviv_gpu *gpu)
 {
-       if (gpu->clk_shader)
-               clk_disable_unprepare(gpu->clk_shader);
-       if (gpu->clk_core)
-               clk_disable_unprepare(gpu->clk_core);
-       if (gpu->clk_bus)
-               clk_disable_unprepare(gpu->clk_bus);
-       if (gpu->clk_reg)
-               clk_disable_unprepare(gpu->clk_reg);
+       clk_disable_unprepare(gpu->clk_shader);
+       clk_disable_unprepare(gpu->clk_core);
+       clk_disable_unprepare(gpu->clk_bus);
+       clk_disable_unprepare(gpu->clk_reg);
 
        return 0;
 }