io_uring: don't put a poll req under spinlock
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 13 Oct 2020 08:43:58 +0000 (09:43 +0100)
committerJens Axboe <axboe@kernel.dk>
Sat, 17 Oct 2020 15:25:42 +0000 (09:25 -0600)
Move io_put_req() in io_poll_task_handler() from under spinlock. This
eliminates the need to use REQ_F_COMP_LOCKED, at the expense of
potentially having to grab the lock again. That's still a better trade
off than relying on the locked flag.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index ca9be31..92546f9 100644 (file)
@@ -4844,10 +4844,9 @@ static void io_poll_task_handler(struct io_kiocb *req, struct io_kiocb **nxt)
 
        hash_del(&req->hash_node);
        io_poll_complete(req, req->result, 0);
-       req->flags |= REQ_F_COMP_LOCKED;
-       *nxt = io_put_req_find_next(req);
        spin_unlock_irq(&ctx->completion_lock);
 
+       *nxt = io_put_req_find_next(req);
        io_cqring_ev_posted(ctx);
 }