bpftool: Fix error return value in build_btf_type_table
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 24 Nov 2020 10:41:00 +0000 (18:41 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 24 Nov 2020 22:19:18 +0000 (23:19 +0100)
An appropriate return value should be set on the failed path.

Fixes: 4d374ba0bf30 ("tools: bpftool: implement "bpftool btf show|list"")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20201124104100.491-1-thunder.leizhen@huawei.com
tools/bpf/bpftool/btf.c

index 8ab142f..2afb7d5 100644 (file)
@@ -693,6 +693,7 @@ build_btf_type_table(struct btf_attach_table *tab, enum bpf_obj_type type,
                obj_node = calloc(1, sizeof(*obj_node));
                if (!obj_node) {
                        p_err("failed to allocate memory: %s", strerror(errno));
+                       err = -ENOMEM;
                        goto err_free;
                }