powerpc/syscall: Calling kuap_save_and_lock() is wrong
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Thu, 6 May 2021 11:56:31 +0000 (11:56 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 12 May 2021 01:07:38 +0000 (11:07 +1000)
kuap_save_and_lock() is only for interrupts inside kernel.

system call are only from user, calling kuap_save_and_lock()
is wrong.

Fixes: c16728835eec ("powerpc/32: Manage KUAP in C")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/332773775cf24a422105dee2d383fb8f04589045.1620302182.git.christophe.leroy@csgroup.eu
arch/powerpc/kernel/interrupt.c

index ed6cebc..e0938ba 100644 (file)
@@ -34,9 +34,6 @@ notrace long system_call_exception(long r3, long r4, long r5,
        syscall_fn f;
 
        kuep_lock();
-#ifdef CONFIG_PPC32
-       kuap_save_and_lock(regs);
-#endif
 
        regs->orig_gpr3 = r3;