smb3: rc uninitialized in one fallocate path
authorSteve French <stfrench@microsoft.com>
Mon, 26 Jul 2021 21:22:55 +0000 (16:22 -0500)
committerSteve French <stfrench@microsoft.com>
Tue, 27 Jul 2021 03:35:46 +0000 (22:35 -0500)
Clang detected a problem with rc possibly being unitialized
(when length is zero) in a recently added fallocate code path.

Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c

index 23d6f4d..2dfd0d8 100644 (file)
@@ -3617,7 +3617,8 @@ static int smb3_simple_fallocate_write_range(unsigned int xid,
                                             char *buf)
 {
        struct cifs_io_parms io_parms = {0};
-       int rc, nbytes;
+       int nbytes;
+       int rc = 0;
        struct kvec iov[2];
 
        io_parms.netfid = cfile->fid.netfid;