arm64: topology: Drop the useless update to per-cpu cycles
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 10 Dec 2020 05:47:40 +0000 (11:17 +0530)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 15 Dec 2020 12:37:59 +0000 (12:37 +0000)
The previous call to update_freq_counters_refs() has already updated the
per-cpu variables, don't overwrite them with the same value again.

Fixes: 4b9cf23c179a ("arm64: wrap and generalise counter read functions")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/7a171f710cdc0f808a2bfbd7db839c0d265527e7.1607579234.git.viresh.kumar@linaro.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/topology.c

index b8026ec..aebeb6f 100644 (file)
@@ -304,7 +304,7 @@ void topology_scale_freq_tick(void)
 
        if (unlikely(core_cnt <= prev_core_cnt ||
                     const_cnt <= prev_const_cnt))
-               goto store_and_exit;
+               return;
 
        /*
         *          /\core    arch_max_freq_scale
@@ -321,10 +321,6 @@ void topology_scale_freq_tick(void)
 
        scale = min_t(unsigned long, scale, SCHED_CAPACITY_SCALE);
        this_cpu_write(freq_scale, (unsigned long)scale);
-
-store_and_exit:
-       this_cpu_write(arch_core_cycles_prev, core_cnt);
-       this_cpu_write(arch_const_cycles_prev, const_cnt);
 }
 
 #ifdef CONFIG_ACPI_CPPC_LIB