cifsd: simplify error handling in ksmbd_auth_ntlm()

simplify error handling in ksmbd_auth_ntlm().

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifsd/auth.c b/fs/cifsd/auth.c
index 092db15..7771429 100644 (file)
--- a/fs/cifsd/auth.c
+++ b/fs/cifsd/auth.c
@@ -351,12 +351,11 @@ int ksmbd_auth_ntlm(struct ksmbd_session *sess, char *pw_buf)
 
        if (strncmp(pw_buf, key, CIFS_AUTH_RESP_SIZE) != 0) {
                ksmbd_debug(AUTH, "ntlmv1 authentication failed\n");
-               rc = -EINVAL;
-       } else {
-               ksmbd_debug(AUTH, "ntlmv1 authentication pass\n");
+               return -EINVAL;
        }
 
-       return rc;
+       ksmbd_debug(AUTH, "ntlmv1 authentication pass\n");
+       return 0;
 }
 
 /**