tools/bootconfig: Simplify expression
authorzuoqilin <zuoqilin@yulong.com>
Wed, 14 Apr 2021 13:46:47 +0000 (21:46 +0800)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 10 Jun 2021 15:16:20 +0000 (11:16 -0400)
It is not necessary to define the variable ret to receive
the return value of the xbc_node_compose_key() method.

Link: https://lkml.kernel.org/r/20210414134647.1870-1-zuoqilin1@163.com
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: zuoqilin <zuoqilin@yulong.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
tools/bootconfig/main.c

index 6cd6080..268b72f 100644 (file)
@@ -84,11 +84,9 @@ static void xbc_show_list(void)
        char key[XBC_KEYLEN_MAX];
        struct xbc_node *leaf;
        const char *val;
-       int ret = 0;
 
        xbc_for_each_key_value(leaf, val) {
-               ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX);
-               if (ret < 0)
+               if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0)
                        break;
                printf("%s = ", key);
                if (!val || val[0] == '\0') {