cpufreq: qcom-cpufreq-nvmem: dev_pm_opp_put_*() accepts NULL argument
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 6 Nov 2020 06:48:39 +0000 (12:18 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 9 Dec 2020 05:51:12 +0000 (11:21 +0530)
The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
there is no need for us to carry the extra checks. Drop them.

Reviewed-by: Ilia Lin <ilia.lin@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/qcom-cpufreq-nvmem.c

index d06b378..747d602 100644 (file)
@@ -397,19 +397,19 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
 
 free_genpd_opp:
        for_each_possible_cpu(cpu) {
-               if (IS_ERR_OR_NULL(drv->genpd_opp_tables[cpu]))
+               if (IS_ERR(drv->genpd_opp_tables[cpu]))
                        break;
                dev_pm_opp_detach_genpd(drv->genpd_opp_tables[cpu]);
        }
        kfree(drv->genpd_opp_tables);
 free_opp:
        for_each_possible_cpu(cpu) {
-               if (IS_ERR_OR_NULL(drv->names_opp_tables[cpu]))
+               if (IS_ERR(drv->names_opp_tables[cpu]))
                        break;
                dev_pm_opp_put_prop_name(drv->names_opp_tables[cpu]);
        }
        for_each_possible_cpu(cpu) {
-               if (IS_ERR_OR_NULL(drv->hw_opp_tables[cpu]))
+               if (IS_ERR(drv->hw_opp_tables[cpu]))
                        break;
                dev_pm_opp_put_supported_hw(drv->hw_opp_tables[cpu]);
        }
@@ -430,12 +430,9 @@ static int qcom_cpufreq_remove(struct platform_device *pdev)
        platform_device_unregister(cpufreq_dt_pdev);
 
        for_each_possible_cpu(cpu) {
-               if (drv->names_opp_tables[cpu])
-                       dev_pm_opp_put_supported_hw(drv->names_opp_tables[cpu]);
-               if (drv->hw_opp_tables[cpu])
-                       dev_pm_opp_put_supported_hw(drv->hw_opp_tables[cpu]);
-               if (drv->genpd_opp_tables[cpu])
-                       dev_pm_opp_detach_genpd(drv->genpd_opp_tables[cpu]);
+               dev_pm_opp_put_supported_hw(drv->names_opp_tables[cpu]);
+               dev_pm_opp_put_supported_hw(drv->hw_opp_tables[cpu]);
+               dev_pm_opp_detach_genpd(drv->genpd_opp_tables[cpu]);
        }
 
        kfree(drv->names_opp_tables);