dmaengine: sh: Fix unused initialization of pointer lmdesc
authorColin Ian King <colin.king@canonical.com>
Sun, 29 Aug 2021 15:28:11 +0000 (16:28 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 31 Aug 2021 16:19:25 +0000 (21:49 +0530)
Pointer lmdesc is being inintialized with a value that is never read,
it is later being re-assigned a new value. Fix this by initializing
it with the latter value.

Addresses-Coverity: ("Unused value")
Fixes: 550c591a89a1 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210829152811.529766-1-colin.king@canonical.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/rz-dmac.c

index 11986a8..3d1c239 100644 (file)
@@ -308,12 +308,10 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_dmac_chan *channel)
 {
        struct dma_chan *chan = &channel->vc.chan;
        struct rz_dmac *dmac = to_rz_dmac(chan->device);
-       struct rz_lmdesc *lmdesc = channel->lmdesc.base;
+       struct rz_lmdesc *lmdesc = channel->lmdesc.tail;
        struct rz_dmac_desc *d = channel->desc;
        u32 chcfg = CHCFG_MEM_COPY;
 
-       lmdesc = channel->lmdesc.tail;
-
        /* prepare descriptor */
        lmdesc->sa = d->src;
        lmdesc->da = d->dest;