binder: Add invalid handle info in user error log
authorRamji Jiyani <ramjiyani@google.com>
Mon, 2 Aug 2021 22:04:45 +0000 (22:04 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Aug 2021 14:29:25 +0000 (16:29 +0200)
In the case of a failed transaction, only the thread and process id are
logged. Add the handle info for the reference to the target node in user
error log to aid debugging.

Acked-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Ramji Jiyani <ramjiyani@google.com>
Link: https://lore.kernel.org/r/20210802220446.1938347-1-ramjiyani@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index bcec598..d9030cb 100644 (file)
@@ -2547,8 +2547,8 @@ static void binder_transaction(struct binder_proc *proc,
                                                ref->node, &target_proc,
                                                &return_error);
                        } else {
-                               binder_user_error("%d:%d got transaction to invalid handle\n",
-                                                 proc->pid, thread->pid);
+                               binder_user_error("%d:%d got transaction to invalid handle, %u\n",
+                                                 proc->pid, thread->pid, tr->target.handle);
                                return_error = BR_FAILED_REPLY;
                        }
                        binder_proc_unlock(proc);