iommu/amd: Clean up the cmpxchg64 invocation
authorBaoquan He <bhe@redhat.com>
Thu, 15 Sep 2016 08:50:50 +0000 (16:50 +0800)
committerJoerg Roedel <jroedel@suse.de>
Mon, 19 Sep 2016 13:49:01 +0000 (15:49 +0200)
Change it as it's designed for and keep it consistent with other
places.

Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd_iommu.c

index bebe728..897940c 100644 (file)
@@ -1342,7 +1342,8 @@ static u64 *alloc_pte(struct protection_domain *domain,
 
                        __npte = PM_LEVEL_PDE(level, virt_to_phys(page));
 
-                       if (cmpxchg64(pte, __pte, __npte)) {
+                       /* pte could have been changed somewhere. */
+                       if (cmpxchg64(pte, __pte, __npte) != __pte) {
                                free_page((unsigned long)page);
                                continue;
                        }