x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Fri, 1 Jun 2018 14:59:21 +0000 (10:59 -0400)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 6 Jun 2018 12:13:17 +0000 (14:13 +0200)
Both AMD and Intel can have SPEC_CTRL_MSR for SSBD.

However AMD also has two more other ways of doing it - which
are !SPEC_CTRL MSR ways.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Kees Cook <keescook@chromium.org>
Cc: kvm@vger.kernel.org
Cc: KarimAllah Ahmed <karahmed@amazon.de>
Cc: andrew.cooper3@citrix.com
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lkml.kernel.org/r/20180601145921.9500-4-konrad.wilk@oracle.com
arch/x86/kernel/cpu/bugs.c

index 6bea818..cd0fda1 100644 (file)
@@ -532,17 +532,12 @@ static enum ssb_mitigation __init __ssb_select_mitigation(void)
                 * Intel uses the SPEC CTRL MSR Bit(2) for this, while AMD may
                 * use a completely different MSR and bit dependent on family.
                 */
-               switch (boot_cpu_data.x86_vendor) {
-               case X86_VENDOR_INTEL:
-               case X86_VENDOR_AMD:
-                       if (!static_cpu_has(X86_FEATURE_MSR_SPEC_CTRL)) {
-                               x86_amd_ssb_disable();
-                               break;
-                       }
+               if (!static_cpu_has(X86_FEATURE_MSR_SPEC_CTRL))
+                       x86_amd_ssb_disable();
+               else {
                        x86_spec_ctrl_base |= SPEC_CTRL_SSBD;
                        x86_spec_ctrl_mask |= SPEC_CTRL_SSBD;
                        wrmsrl(MSR_IA32_SPEC_CTRL, x86_spec_ctrl_base);
-                       break;
                }
        }